From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC142C3815B for ; Wed, 15 Apr 2020 08:47:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDE66206F9 for ; Wed, 15 Apr 2020 08:47:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="OQYquMdQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2894979AbgDOIrc (ORCPT ); Wed, 15 Apr 2020 04:47:32 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:36832 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895027AbgDOIr2 (ORCPT ); Wed, 15 Apr 2020 04:47:28 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586940448; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=fvi4ED+QTGD3lFB2nEF4L9OZBm+1tfFfScpv1utfIDM=; b=OQYquMdQtA/7iOoBLCZSNjxZmrVMT/dWzPvFY7Oklj7o/V7/+QxMNXUPTLPCkvOoc0F3/wQX p1KtNv+hLDkmlP0d+htONlIoqFsM9PMkoOVCtL+cGIqdVhr+36qqJi6nETGkm6jZceYTgeKz YoMmsmtiy+8toyMhqSw7GdR87b0= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e96ca1c.7fe7ecffb880-smtp-out-n02; Wed, 15 Apr 2020 08:47:24 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BC0D7C433F2; Wed, 15 Apr 2020 08:47:23 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B0301C433BA; Wed, 15 Apr 2020 08:47:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B0301C433BA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] orinoco: remove useless variable 'err' in spectrum_cs_suspend() From: Kalle Valo In-Reply-To: <20200413082043.22468-1-yanaijie@huawei.com> References: <20200413082043.22468-1-yanaijie@huawei.com> To: Jason Yan Cc: , , , , , Hulk Robot User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200415084723.BC0D7C433F2@smtp.codeaurora.org> Date: Wed, 15 Apr 2020 08:47:23 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/intersil/orinoco/spectrum_cs.c:281:5-8: Unneeded > variable: "err". Return "0" on line 286 > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Patch applied to wireless-drivers-next.git, thanks. 7b9ae69d5441 orinoco: remove useless variable 'err' in spectrum_cs_suspend() -- https://patchwork.kernel.org/patch/11485247/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches