From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F2CC352BE for ; Fri, 17 Apr 2020 11:12:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83A6D221EC for ; Fri, 17 Apr 2020 11:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587121931; bh=MUG7MxQRnqIRzgMzXlRZSVXLEa67kjsJeT81XFUo30o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tU9Oy3VbLkHAY3Yg6cwH9RuLHi2srJw4yc3iVUI8YPtWHNVEGTDK5IL+znBDgQqIU 1gKBnSSYbrmArPJNT7r2WmOxNO+1mj8MutHCuE1k+qeNjNxeyxZdiWFzhhor0ldztn 1tEeRpROCX8rpwRJFXxnrTeVHpFXU+laPLX9Zg2Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730222AbgDQLML (ORCPT ); Fri, 17 Apr 2020 07:12:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:39940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730091AbgDQLMK (ORCPT ); Fri, 17 Apr 2020 07:12:10 -0400 Received: from linux-8ccs (p3EE2C7AC.dip0.t-ipconnect.de [62.226.199.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9BAA521D95; Fri, 17 Apr 2020 11:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587121930; bh=MUG7MxQRnqIRzgMzXlRZSVXLEa67kjsJeT81XFUo30o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SUa4yjiEi9BYuvlcnAC7Gmqq3Di56eau2EtUMk6sMt15x+bnOZ5RAKdtwc0+dtdJa 0nNw0ZIhbVznDqnz1Nlf0wyUxWc2foeJKKk+/bxLR8bv8IWIUrkpl0BfSUezTw+lmJ SVW1c9WRKw7QiB92K81e8jgYGXrvKgfKzz81ZISI= Date: Fri, 17 Apr 2020 13:12:05 +0200 From: Jessica Yu To: Leon Romanovsky Cc: "David S . Miller" , Jakub Kicinski , Leon Romanovsky , Borislav Petkov , linux-kbuild@vger.kernel.org, Masahiro Yamada , Michal Marek , netdev@vger.kernel.org Subject: Re: [PATCH net-next v1 4/4] kernel/module: Hide vermagic header file from general use Message-ID: <20200417111205.GB2582@linux-8ccs> References: <20200415133648.1306956-1-leon@kernel.org> <20200415133648.1306956-5-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200415133648.1306956-5-leon@kernel.org> X-OS: Linux linux-8ccs 4.12.14-lp150.12.61-default x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org +++ Leon Romanovsky [15/04/20 16:36 +0300]: >From: Leon Romanovsky > >VERMAGIC* definitions are not supposed to be used by the drivers, >see this [1] bug report, so simply move this header file to be visible >to kernel/* and scripts files only. > >In-tree module build: >➜ kernel git:(vermagic) ✗ make clean >➜ kernel git:(vermagic) ✗ make M=drivers/infiniband/hw/mlx5 >➜ kernel git:(vermagic) ✗ modinfo drivers/infiniband/hw/mlx5/mlx5_ib.ko >filename: /images/leonro/src/kernel/drivers/infiniband/hw/mlx5/mlx5_ib.ko ><...> >vermagic: 5.6.0+ SMP mod_unload modversions > >Out-of-tree module build: >➜ mlx5 make -C /images/leonro/src/kernel clean M=/tmp/mlx5 >➜ mlx5 make -C /images/leonro/src/kernel M=/tmp/mlx5 >➜ mlx5 modinfo /tmp/mlx5/mlx5_ib.ko >filename: /tmp/mlx5/mlx5_ib.ko ><...> >vermagic: 5.6.0+ SMP mod_unload modversions > >[1] https://lore.kernel.org/lkml/20200411155623.GA22175@zn.tnic >Reported-by: Borislav Petkov >Acked-by: Borislav Petkov >Signed-off-by: Leon Romanovsky Acked-by: Jessica Yu