From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C988C38A2C for ; Fri, 17 Apr 2020 14:08:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BF28214AF for ; Fri, 17 Apr 2020 14:08:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="gy59aPv8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730894AbgDQOHz (ORCPT ); Fri, 17 Apr 2020 10:07:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1730843AbgDQOHx (ORCPT ); Fri, 17 Apr 2020 10:07:53 -0400 Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B93BC061A10 for ; Fri, 17 Apr 2020 07:07:53 -0700 (PDT) Received: by mail-qv1-xf41.google.com with SMTP id bu9so892576qvb.13 for ; Fri, 17 Apr 2020 07:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+LqhOO57sChESg9+cIngyrXtjaLelgEgf+v+L/tbLWk=; b=gy59aPv8zMj56Mv03vyLFGLBjHJ7J1u+UArIzN0R+rT72xnw/cutPk5HRKX2d/1xSE hKj5WfRwjwgNBiBwpu21u9UkwU1NN7FZGkJLCpxItWEKZUwsINzhO6JPR6PivXLj7MQo DzlEdqiF/kNV0iIENDraE2hef4Q3wXijNqzULS2WDLUwm63Q6O7Y1oO0EPjvaSWN7MD0 AunwqeklzSrYcvc3UTO2x5yR3FPVWYFM74ybRxl3Xmx6E1s4oWCv/m8igVBmhfwOLa12 kXgIX2z40DDQpn1mBfE7DJmt9RJZ1SuirkW4fEIj9HgNfMqTedHLx/oI8bh09LtR45/s R9gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+LqhOO57sChESg9+cIngyrXtjaLelgEgf+v+L/tbLWk=; b=IvFvlWqnSurOUseCbelBzz6whB+SM9Dty6rFAthEhDmzZci+xgc4eejkGXn2Ui79ht mRvLEnvF97L9QwP9Tfbk9Ii6Do9zGd4f4ZgECUUdg3KViYzjlX5Pcvyhen+rDbS9WfUj 9gmgtzQ1adqfhPrpwS9VhITQWuxEC29X2uV+YtvyZ2oN7syze27Ia2uUmbo2vvlUXOA3 J2sbvpPwXlzp/DHsCWVAnq1R2PQeo+/+ebB9CCjGL4r5rmGYCDQT3wMoJqg4al13Z/E4 fQ2ZPLmpZpGkuNBoFtPEgXOAGNS2o77YzJBuqJ2gFE5w5yXNx5Bg/PqjYFEvpWOvVjPQ z2tw== X-Gm-Message-State: AGi0PublyyN8QZoQ6ACMg/KM1lrAD8jDwsoCoqGVxsiA54iaJX7smPKs LuFke7J/k4d8WFq0uxWndilyrw== X-Google-Smtp-Source: APiQypKaGok3DQChb57xxsDjD/Iyacg7EOqm08DjV1CqcQ8BJaa7llQ5QiLWdRU37gbKKcQtu2odUg== X-Received: by 2002:a0c:b790:: with SMTP id l16mr2844426qve.244.1587132472350; Fri, 17 Apr 2020 07:07:52 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id n190sm16749764qkb.93.2020.04.17.07.07.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Apr 2020 07:07:51 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jPReo-0000hP-VC; Fri, 17 Apr 2020 11:07:50 -0300 Date: Fri, 17 Apr 2020 11:07:50 -0300 From: Jason Gunthorpe To: Jani Nikula Cc: Saeed Mahameed , Masahiro Yamada , linux-kbuild@vger.kernel.org, Arnd Bergmann , Nicolas Pitre , narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com, leon@kernel.org, kieran.bingham+renesas@ideasonboard.com, jonas@kwiboo.se, airlied@linux.ie, jernej.skrabec@siol.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, Andrzej Hajda Subject: Re: [RFC PATCH 1/2] Kconfig: Introduce "uses" keyword Message-ID: <20200417140750.GF26002@ziepe.ca> References: <20200417011146.83973-1-saeedm@mellanox.com> <87v9ly3a0w.fsf@intel.com> <20200417122827.GD5100@ziepe.ca> <87h7xi2oup.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h7xi2oup.fsf@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 17, 2020 at 05:01:18PM +0300, Jani Nikula wrote: > On Fri, 17 Apr 2020, Jason Gunthorpe wrote: > > On Fri, Apr 17, 2020 at 09:23:59AM +0300, Jani Nikula wrote: > > > >> Which means that would have to split up to two. Not ideal, but > >> doable. > > > > Why is this not ideal? > > > > I think the one per line is easier to maintain (eg for merge > > conflicts) and easier to read than a giant && expression. > > > > I would not complicate things further by extending the boolean > > language.. > > Fair enough. I only found one instance where the patch at hand does not > cut it: > > drivers/hwmon/Kconfig: depends on !OF || IIO=n || IIO Ideally this constraint would be expressed as: optionally depends on OF && IIO And if the expression is n then IIO is not prevented from being y. Ie the code is just doing: #if defined(CONFIG_OF) && IS_ENABLED(CONFIG_IIO) Jason