From: Andrew Lunn <andrew@lunn.ch>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH] net: phy: marvell10g: hwmon support for 2110
Date: Fri, 17 Apr 2020 17:48:36 +0200 [thread overview]
Message-ID: <20200417154836.GB785713@lunn.ch> (raw)
In-Reply-To: <18fe946c32093f50462e026090a9e32eb568c8c5.1587103852.git.baruch@tkos.co.il>
On Fri, Apr 17, 2020 at 09:10:52AM +0300, Baruch Siach wrote:
> Read the temperature sensor register from the correct location for the
> 88E2110 PHY. There is no enable/disable bit, so leave
> mv3310_hwmon_config() for 88X3310 only.
Nice. Thanks for doing this.
> @@ -191,7 +201,8 @@ static int mv3310_hwmon_probe(struct phy_device *phydev)
> struct mv3310_priv *priv = dev_get_drvdata(&phydev->mdio.dev);
> int i, j, ret;
>
> - if (phydev->drv->phy_id != MARVELL_PHY_ID_88X3310)
> + if (phydev->drv->phy_id != MARVELL_PHY_ID_88X3310 &&
> + phydev->drv->phy_id != MARVELL_PHY_ID_88E2110)
> return 0;
The indentation looks wrong here?
Thanks
Andrew
next prev parent reply other threads:[~2020-04-17 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 6:10 [PATCH] net: phy: marvell10g: hwmon support for 2110 Baruch Siach
2020-04-17 15:48 ` Andrew Lunn [this message]
2020-04-19 6:44 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417154836.GB785713@lunn.ch \
--to=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).