From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EA5C38A2B for ; Fri, 17 Apr 2020 19:39:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE2AB22243 for ; Fri, 17 Apr 2020 19:39:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="MysNWm+Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730611AbgDQTjK (ORCPT ); Fri, 17 Apr 2020 15:39:10 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45034 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730336AbgDQTjJ (ORCPT ); Fri, 17 Apr 2020 15:39:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5wbOmjfBKlirMRvp5xkC4Vfb3UzqF4kW6GaX+rtLC0w=; b=MysNWm+Y2KusXIbmHXxDn1//Qv lmbrRrLEkeVCG+iEB0C0OrfMinRn1UVeI6mD+HHpRourTk3OftiF7Lz3FKcGF89362FLHYkjt1Nxz DIuA5NLySaGnnqp7dNYaGovpinRPtaPD2Qb9+KeQUBxfC4d6VEvx+/2ETsh4TwlDY808=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jPWpN-003LEM-6k; Fri, 17 Apr 2020 21:39:05 +0200 Date: Fri, 17 Apr 2020 21:39:05 +0200 From: Andrew Lunn To: Michael Walle Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jean Delvare , Guenter Roeck , Florian Fainelli , Heiner Kallweit , Russell King , "David S . Miller" Subject: Re: [PATCH net-next 2/3] net: phy: add Broadcom BCM54140 support Message-ID: <20200417193905.GF785713@lunn.ch> References: <20200417192858.6997-1-michael@walle.cc> <20200417192858.6997-2-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200417192858.6997-2-michael@walle.cc> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 17, 2020 at 09:28:57PM +0200, Michael Walle wrote: > +static int bcm54140_get_base_addr_and_port(struct phy_device *phydev) > +{ > + struct bcm54140_phy_priv *priv = phydev->priv; > + struct mii_bus *bus = phydev->mdio.bus; > + int addr, min_addr, max_addr; > + int step = 1; > + u32 phy_id; > + int tmp; > + > + min_addr = phydev->mdio.addr; > + max_addr = phydev->mdio.addr; > + addr = phydev->mdio.addr; > + > + /* We scan forward and backwards and look for PHYs which have the > + * same phy_id like we do. Step 1 will scan forward, step 2 > + * backwards. Once we are finished, we have a min_addr and > + * max_addr which resembles the range of PHY addresses of the same > + * type of PHY. There is one caveat; there may be many PHYs of > + * the same type, but we know that each PHY takes exactly 4 > + * consecutive addresses. Therefore we can deduce our offset > + * to the base address of this quad PHY. > + */ Hi Michael How much flexibility is there in setting the base address using strapping etc? Is it limited to a multiple of 4?