From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
fugang.duan@nxp.com, Chris Healy <Chris.Healy@zii.aero>
Subject: Re: [PATCH net-next v2 3/3] net: ethernet: fec: Allow the MDIO preamble to be disabled
Date: Sat, 18 Apr 2020 16:27:58 +0200 [thread overview]
Message-ID: <20200418142758.GC804711@lunn.ch> (raw)
In-Reply-To: <bde059d8-5a95-d32b-7e28-ac7385cc0415@gmail.com>
> This is a property of the MDIO device node and the MDIO bus controller as
> well, so I would assume that it has to be treated a little it like the
> 'broken-turn-around' property and it would have to be a bitmask per MDIO
> device address that is set/clear depending on what the device support. If it
> is set for the device and your controller supports it, then you an suppress
> preamble.
Again, i don't see how this can work. You need all the devices on the
bus to support preamble suppression, otherwise you cannot use it. As
with a maximum clock frequency, we could add the complexity to check
as bus scan time that all devices have the necessary property, but i
don't think it brings anything.
Andrew
next prev parent reply other threads:[~2020-04-18 14:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 0:03 [PATCH net-next v2 0/3] FEC MDIO speedups Andrew Lunn
2020-04-18 0:03 ` [PATCH net-next v2 1/3] net: ethernet: fec: Replace interrupt driven MDIO with polled IO Andrew Lunn
2020-04-18 13:55 ` [EXT] " Andy Duan
2020-04-18 22:39 ` Chris Healy
2020-04-19 0:35 ` Andrew Lunn
2020-04-19 6:22 ` Andy Duan
2020-04-19 20:47 ` Andrew Lunn
2020-04-18 16:21 ` Fabio Estevam
2020-04-18 21:06 ` Florian Fainelli
2020-04-18 0:03 ` [PATCH net-next v2 2/3] net: ethernet: fec: Allow configuration of MDIO bus speed Andrew Lunn
2020-04-18 0:34 ` Florian Fainelli
2020-04-18 14:23 ` Andrew Lunn
2020-04-18 16:01 ` Florian Fainelli
2020-04-18 16:49 ` Andrew Lunn
2020-04-18 21:07 ` Florian Fainelli
2020-04-18 21:08 ` Florian Fainelli
2020-04-18 0:03 ` [PATCH net-next v2 3/3] net: ethernet: fec: Allow the MDIO preamble to be disabled Andrew Lunn
2020-04-18 0:39 ` Florian Fainelli
2020-04-18 14:27 ` Andrew Lunn [this message]
2020-04-18 16:02 ` Florian Fainelli
2020-04-18 21:09 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418142758.GC804711@lunn.ch \
--to=andrew@lunn.ch \
--cc=Chris.Healy@zii.aero \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).