From: Sasha Levin <sashal@kernel.org>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Stable <stable@vger.kernel.org>, Aya Levin <ayal@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH AUTOSEL 5.5 006/106] net/mlx5e: Enforce setting of a single FEC mode
Date: Sat, 18 Apr 2020 17:20:44 -0400 [thread overview]
Message-ID: <20200418212044.GE1809@sasha-vm> (raw)
In-Reply-To: <CAJ3xEMjKozXW1h8Dwv96VzCegOsyvyyeZ4hapWzwStirLGnAqg@mail.gmail.com>
On Sat, Apr 18, 2020 at 10:52:59PM +0300, Or Gerlitz wrote:
>On Thu, Apr 16, 2020 at 2:56 AM Sasha Levin <sashal@kernel.org> wrote:
>> From: Aya Levin <ayal@mellanox.com>
>> [ Upstream commit 4bd9d5070b92da012f2715cf8e4859acb78b8f35 ]
>>
>> Ethtool command allow setting of several FEC modes in a single set
>> command. The driver can only set a single FEC mode at a time. With this
>> patch driver will reply not-supported on setting several FEC modes.
>>
>> Signed-off-by: Aya Levin <ayal@mellanox.com>
>> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>> drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++++
>
>Haven't we agreed that drivers/net/ethernet/mellanox/mlx5 is not
>subject to autosel anymore?!
On Thu, Apr 16, 2020 at 09:08:06PM +0000, Saeed Mahameed wrote:
>Please don't opt mlx5 out just yet ;-), i need to do some more research
>and make up my mind..
It would be awesome if the Mellanox folks could agree between
themselves whether they want it or not and let us know which option they
pick.
Again, I really don't care whether mlx5 is opted out or not, I'm not
going to argue with anyone if you want to opt out, I just want to know
whether you're out or not :)
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-04-18 21:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200415114226.13103-1-sashal@kernel.org>
2020-04-15 11:40 ` [PATCH AUTOSEL 5.5 006/106] net/mlx5e: Enforce setting of a single FEC mode Sasha Levin
2020-04-18 19:52 ` Or Gerlitz
2020-04-18 21:20 ` Sasha Levin [this message]
2020-04-19 9:05 ` Or Gerlitz
2020-04-15 11:40 ` [PATCH AUTOSEL 5.5 009/106] bpf: Reliably preserve btf_trace_xxx types Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 055/106] net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035 Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 056/106] cxgb4: fix MPS index overwrite when setting MAC address Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 057/106] slcan: Don't transmit uninitialized stack data in padding Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 058/106] net: qualcomm: rmnet: Allow configuration updates to existing devices Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 060/106] net: stmmac: dwmac1000: fix out-of-bounds mac address reg setting Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 061/106] net: dsa: mt7530: fix null pointer dereferencing in port5 setup Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 062/106] tun: Don't put_page() for all negative return values from XDP program Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 063/106] mlxsw: spectrum_flower: Do not stop at FLOW_ACTION_VLAN_MANGLE Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 064/106] net: dsa: bcm_sf2: Do not register slave MDIO bus with OF Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 074/106] net: dsa: bcm_sf2: Ensure correct sub-node is parsed Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 076/106] net: phy: micrel: kszphy_resume(): add delay after genphy_resume() before accessing PHY registers Sasha Levin
2020-04-15 11:41 ` [PATCH AUTOSEL 5.5 078/106] net: stmmac: xgmac: Fix VLAN register handling Sasha Levin
2020-04-15 11:42 ` [PATCH AUTOSEL 5.5 080/106] cxgb4: free MQPRIO resources in shutdown path Sasha Levin
2020-04-15 11:42 ` [PATCH AUTOSEL 5.5 090/106] SUNRPC: fix krb5p mount to provide large enough buffer in rq_rcvsize Sasha Levin
2020-04-15 11:42 ` [PATCH AUTOSEL 5.5 098/106] sunrpc: Fix gss_unwrap_resp_integ() again Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418212044.GE1809@sasha-vm \
--to=sashal@kernel.org \
--cc=ayal@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).