From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E22C2BA19 for ; Sat, 18 Apr 2020 21:21:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45E4221D6C for ; Sat, 18 Apr 2020 21:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587244867; bh=2QTKjiopYEAmsX3oKHr1d4x/yXdKgoAiCY9R5mVgWxg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XOZbooqrZTBVQp1TqyeljKd+7eU4MrEcgsYp90gi+/oHHeYlW6fpAu+3cz+Vhi4ND UIaILY/f3d1o4B45XY17SeAZHXP4fbM7LgArDm/eOxkuyolgkSAgWA9Wu9ApXJ+8TU 5xyAmQ5NMMdyttdxj8MVut4TxRsGlbtdjasmwxtA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbgDRVUq (ORCPT ); Sat, 18 Apr 2020 17:20:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:41778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbgDRVUq (ORCPT ); Sat, 18 Apr 2020 17:20:46 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD34921D6C; Sat, 18 Apr 2020 21:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587244846; bh=2QTKjiopYEAmsX3oKHr1d4x/yXdKgoAiCY9R5mVgWxg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yQNIS0f67zLk1LDfck/vteQMw+YvycUdXU3cvwokPVioE3B/5nrmA5cWWkKqrhR8m ARNsdxU6Yx56/tS0/c7ztVULPjFdsADkVPfEMOJlI1MsehMhODT5GjvLZftZZVB6do h31oeoxvn91qqqots+htICc73GmGMlWLSqGAqkVA= Date: Sat, 18 Apr 2020 17:20:44 -0400 From: Sasha Levin To: Or Gerlitz Cc: Stable , Aya Levin , Saeed Mahameed , Linux Netdev List Subject: Re: [PATCH AUTOSEL 5.5 006/106] net/mlx5e: Enforce setting of a single FEC mode Message-ID: <20200418212044.GE1809@sasha-vm> References: <20200415114226.13103-1-sashal@kernel.org> <20200415114226.13103-6-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Apr 18, 2020 at 10:52:59PM +0300, Or Gerlitz wrote: >On Thu, Apr 16, 2020 at 2:56 AM Sasha Levin wrote: >> From: Aya Levin >> [ Upstream commit 4bd9d5070b92da012f2715cf8e4859acb78b8f35 ] >> >> Ethtool command allow setting of several FEC modes in a single set >> command. The driver can only set a single FEC mode at a time. With this >> patch driver will reply not-supported on setting several FEC modes. >> >> Signed-off-by: Aya Levin >> Signed-off-by: Saeed Mahameed >> Signed-off-by: Sasha Levin >> --- >> drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++++ > >Haven't we agreed that drivers/net/ethernet/mellanox/mlx5 is not >subject to autosel anymore?! On Thu, Apr 16, 2020 at 09:08:06PM +0000, Saeed Mahameed wrote: >Please don't opt mlx5 out just yet ;-), i need to do some more research >and make up my mind.. It would be awesome if the Mellanox folks could agree between themselves whether they want it or not and let us know which option they pick. Again, I really don't care whether mlx5 is opted out or not, I'm not going to argue with anyone if you want to opt out, I just want to know whether you're out or not :) -- Thanks, Sasha