From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
jiri@resnulli.us
Subject: [PATCH net] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DISABLED
Date: Sun, 19 Apr 2020 13:53:38 +0200 [thread overview]
Message-ID: <20200419115338.659487-1-pablo@netfilter.org> (raw)
If the frontend requests no stats through FLOW_ACTION_HW_STATS_DISABLED,
drivers that are checking for the hw stats configuration bail out with
EOPNOTSUPP.
Fixes: 319a1d19471e ("flow_offload: check for basic action hw stats type")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
include/net/flow_offload.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
index 3619c6acf60f..c2519a25d0bd 100644
--- a/include/net/flow_offload.h
+++ b/include/net/flow_offload.h
@@ -326,6 +326,9 @@ __flow_action_hw_stats_check(const struct flow_action *action,
if (!flow_action_mixed_hw_stats_check(action, extack))
return false;
action_entry = flow_action_first_entry_get(action);
+ if (action_entry->hw_stats == FLOW_ACTION_HW_STATS_DISABLED)
+ return true;
+
if (!check_allow_bit &&
action_entry->hw_stats != FLOW_ACTION_HW_STATS_ANY) {
NL_SET_ERR_MSG_MOD(extack, "Driver supports only default HW stats type \"any\"");
--
2.11.0
next reply other threads:[~2020-04-19 11:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 11:53 Pablo Neira Ayuso [this message]
2020-04-20 8:02 ` [PATCH net] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DISABLED Jiri Pirko
2020-04-20 9:05 ` Pablo Neira Ayuso
2020-04-20 9:13 ` Jiri Pirko
2020-04-20 10:03 ` Pablo Neira Ayuso
2020-04-20 11:52 ` Jiri Pirko
2020-04-20 12:13 ` Pablo Neira Ayuso
2020-04-20 13:49 ` Jiri Pirko
2020-04-20 12:28 ` Edward Cree
2020-04-20 12:36 ` Jiri Pirko
2020-04-20 12:49 ` Pablo Neira Ayuso
2020-04-20 13:46 ` Jiri Pirko
2020-04-20 12:39 ` Pablo Neira Ayuso
2020-04-20 13:48 ` Jiri Pirko
2020-04-20 13:57 ` Florian Westphal
2020-04-20 14:14 ` Jiri Pirko
2020-04-20 19:18 ` Pablo Neira Ayuso
2020-04-22 18:37 ` Jiri Pirko
2020-04-27 14:31 ` Edward Cree
2020-04-27 18:12 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200419115338.659487-1-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).