From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 3/3] net: phy: bcm54140: add hwmon support
Date: Sun, 19 Apr 2020 23:55:49 +0200 [thread overview]
Message-ID: <20200419215549.GR836632@lunn.ch> (raw)
In-Reply-To: <0f7ea4522a76f977f3aa3a80dd62201d@walle.cc>
> But what does that have to do with the shared structure? I don't think
> you have to "bundle" the shared structure with the "access the global
> registers" method.
We don't need to. But it would be a good way to clean up code which
locks the mdio bus, does a register access on some other device, and
then unlocks the bus.
As a general rule of thumb, it is better to have the core do the
locking, rather than the driver. Driver writers don't always think
about locking, so it is better to give driver writers safe APIs to
use.
Andrew
next prev parent reply other threads:[~2020-04-19 21:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 19:28 [PATCH net-next 1/3] net: phy: broadcom: add helper to write/read RDB registers Michael Walle
2020-04-17 19:28 ` [PATCH net-next 2/3] net: phy: add Broadcom BCM54140 support Michael Walle
2020-04-17 19:39 ` Andrew Lunn
2020-04-17 19:50 ` Michael Walle
2020-04-17 20:00 ` Vladimir Oltean
2020-04-17 21:04 ` Michael Walle
2020-04-17 20:12 ` Andrew Lunn
2020-04-17 19:28 ` [PATCH net-next 3/3] net: phy: bcm54140: add hwmon support Michael Walle
2020-04-17 19:50 ` Andrew Lunn
2020-04-17 19:53 ` Michael Walle
2020-04-17 20:13 ` Andrew Lunn
2020-04-17 21:08 ` Michael Walle
2020-04-17 21:28 ` Andrew Lunn
2020-04-19 10:29 ` Michael Walle
2020-04-19 16:29 ` Andrew Lunn
2020-04-19 16:47 ` Michael Walle
2020-04-19 17:05 ` Andrew Lunn
2020-04-19 21:31 ` Michael Walle
2020-04-19 21:55 ` Andrew Lunn [this message]
2020-04-20 15:10 ` Michael Walle
2020-04-20 15:36 ` Andrew Lunn
2020-04-20 16:11 ` Michael Walle
2020-04-20 17:20 ` Russell King - ARM Linux admin
2020-04-19 17:12 ` Russell King - ARM Linux admin
2020-04-18 3:09 ` Guenter Roeck
2020-04-17 19:34 ` [PATCH net-next 1/3] net: phy: broadcom: add helper to write/read RDB registers Florian Fainelli
2020-04-18 14:13 ` Andrew Lunn
2020-04-18 15:55 ` Florian Fainelli
2020-04-18 20:09 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200419215549.GR836632@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).