Re: [PATCH net] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DISABLED

Edward Cree
2020-04-27T14:32:05Z

On 22/04/2020 19:37, Jiri Pirko wrote:
> "Any" can't be "don't care". TC User expects stats. That's default.
>
> Let's have "don't care" bit only and set it for
> ethtool/netfilter/flowtable. Don't change any. Teach the drivers to deal
> with "don't care", most probably using the default checker.
I think the right solution is either this, or the semantically-similar
approach of "0 means don't care, we have a bit for disabled, and ANY
(the TC default) is "all the bits except disabled", i.e.
DELAYED | IMMEDIATE.  That seems slightly cleaner to me, as then non-
zero settings are always "here is a bitmask of options, driver may
choose any of them".  (And 0 differs from DELAYED | IMMEDIATE | DISABLED
only in that if new bits are added to kernel, 0 includes them.)
And of course either way the TC uAPI needs to be able to specify the
new "don't care" option.

-ed