From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jeremy Linton <jeremy.linton@arm.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 5/5] net: bcmgenet: Drop too many parentheses in bcmgenet_probe()
Date: Tue, 21 Apr 2020 00:51:21 +0300 [thread overview]
Message-ID: <20200420215121.17735-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20200420215121.17735-1-andriy.shevchenko@linux.intel.com>
No need to have parentheses around plain pointer variable or
negation operator. Drop them for good.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 2c9881032a24..20aba79becce 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -3529,7 +3529,7 @@ static int bcmgenet_probe(struct platform_device *pdev)
if (device_get_phy_mode(&pdev->dev) == PHY_INTERFACE_MODE_INTERNAL)
bcmgenet_power_up(priv, GENET_POWER_PASSIVE);
- if ((pd) && (!IS_ERR_OR_NULL(pd->mac_address)))
+ if (pd && !IS_ERR_OR_NULL(pd->mac_address))
ether_addr_copy(dev->dev_addr, pd->mac_address);
else
if (!device_get_mac_address(&pdev->dev, dev->dev_addr, ETH_ALEN))
--
2.26.1
next prev parent reply other threads:[~2020-04-20 21:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 21:51 [PATCH v2 0/5] net: bcmgenet: Clean up after ACPI enablement Andy Shevchenko
2020-04-20 21:51 ` [PATCH v2 1/5] net: bcmgenet: Drop ACPI_PTR() to avoid compiler warning Andy Shevchenko
2020-04-20 21:51 ` [PATCH v2 2/5] net: bcmgenet: Drop useless OF code Andy Shevchenko
2020-04-20 22:09 ` Florian Fainelli
2020-04-20 21:51 ` [PATCH v2 3/5] net: bcmgenet: Use devm_clk_get_optional() to get the clocks Andy Shevchenko
2020-04-20 21:51 ` [PATCH v2 4/5] net: bcmgenet: Use get_unligned_beXX() and put_unaligned_beXX() Andy Shevchenko
2020-04-20 21:51 ` Andy Shevchenko [this message]
2020-04-20 22:09 ` [PATCH v2 5/5] net: bcmgenet: Drop too many parentheses in bcmgenet_probe() Florian Fainelli
2020-04-20 23:25 ` [PATCH v2 0/5] net: bcmgenet: Clean up after ACPI enablement David Miller
2020-04-21 13:14 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420215121.17735-6-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jeremy.linton@arm.com \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).