From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A48C54FC9 for ; Tue, 21 Apr 2020 20:06:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16CCA206D9 for ; Tue, 21 Apr 2020 20:06:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726285AbgDUUGm convert rfc822-to-8bit (ORCPT ); Tue, 21 Apr 2020 16:06:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgDUUGl (ORCPT ); Tue, 21 Apr 2020 16:06:41 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD24C0610D5 for ; Tue, 21 Apr 2020 13:06:41 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6449D128C6D44; Tue, 21 Apr 2020 13:06:40 -0700 (PDT) Date: Tue, 21 Apr 2020 13:06:37 -0700 (PDT) Message-Id: <20200421.130637.1641882866461308403.davem@davemloft.net> To: lesedorucalin01@gmail.com Cc: pabeni@redhat.com, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org Subject: Re: [PATCH v4] net: UDP repair mode for retrieving the send queue of corked UDP socket From: David Miller In-Reply-To: <20200416132242.GA2586@white> References: <20200416132242.GA2586@white> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-2 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 21 Apr 2020 13:06:40 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Leșe Doru Călin Date: Thu, 16 Apr 2020 16:22:42 +0300 > In this year's edition of GSoC, there is a project idea for CRIU to add > support for checkpoint/restore of cork-ed UDP sockets. But to add it, the > kernel API needs to be extended. > > This is what this patch does. It adds UDP "repair mode" for UDP sockets in > a similar approach to the TCP "repair mode", but only the send queue is > necessary to be retrieved. So the patch extends the recv and setsockopt > syscalls. Using UDP_REPAIR option in setsockopt, caller can set the socket > in repair mode. If it is setted, the recv/recvfrom/recvmsg will receive the > write queue and the destination of the data. As in the TCP mode, to change > the repair mode requires the CAP_NET_ADMIN capability and to receive data > the caller is obliged to use the MSG_PEEK flag. > > Signed-off-by: Lese Doru Calin I'm not applying this without any reviews. So if someone cares about this feature they should review this change. Thank you.