From: Sabrina Dubroca <sd@queasysnail.net>
To: Dmitry Bogdanov <dbogdanov@marvell.com>
Cc: Igor Russkikh <irusskikh@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Mark Starovoytov <mstarovoitov@marvell.com>,
Antoine Tenart <antoine.tenart@bootlin.com>
Subject: Re: [EXT] Re: [PATCH net 1/2] net: macsec: update SCI upon MAC address change.
Date: Tue, 21 Apr 2020 19:02:49 +0200 [thread overview]
Message-ID: <20200421170249.GA4054840@bistromath.localdomain> (raw)
In-Reply-To: <BYAPR18MB235709AA95C28FAD4C6C39C2A4D40@BYAPR18MB2357.namprd18.prod.outlook.com>
2020-04-20, 09:51:23 +0000, Dmitry Bogdanov wrote:
> Hi Sabrina,
>
> Thanks for the feedback.
> But this patch does not directly related to send_sci parameter.
>
> Any manual change of macsec interface by ip tool will break
> wpa_supplicant work. It's OK, they are not intended to be used
> together.
Are you sure? Before this patch, if you change the MAC address on a
macsec device with "send_sci on", packets can still be encrypted and
decrypted correctly.
> Having a different MAC address on each macsec interface allows to
> make a configuration with several *offloaded* SecY.
If you need to change the MAC address on the macsec device anyway, why
not do that at creation? Then the SCI is already picked:
ip link add link ens3 macsec0 addr 92:23:25:22:bf:bc type macsec
ip macsec show
13: macsec0: [...]
[...]
TXSC: 92232522bfbc0001 on SA 0
> That is to make
> feasible to route the ingress decrypted traffic to the right
> (macsecX /ethX) interface by DST address. And to apply a different
> SecY for the egress packets by SRC address. That is the only option
> for the macsec offload at PHY level when upper layers know nothing
> about macsec.
I see. It would have been nice to have all this information in the
commit message.
I'm concerned about the software implementation, and that patch
is changing its behavior, AFAICT without fixing a bug in it.
--
Sabrina
next prev parent reply other threads:[~2020-04-21 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 15:22 [PATCH net 0/2] MACSec bugfixes related to MAC address change Igor Russkikh
2020-03-10 15:22 ` [PATCH net 1/2] net: macsec: update SCI upon " Igor Russkikh
2020-04-17 9:05 ` Sabrina Dubroca
2020-04-20 9:51 ` [EXT] " Dmitry Bogdanov
2020-04-21 17:02 ` Sabrina Dubroca [this message]
2020-03-10 15:22 ` [PATCH net 2/2] net: macsec: invoke mdo_upd_secy callback when mac address changed Igor Russkikh
2020-03-10 23:02 ` [PATCH net 0/2] MACSec bugfixes related to MAC address change David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421170249.GA4054840@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=antoine.tenart@bootlin.com \
--cc=dbogdanov@marvell.com \
--cc=irusskikh@marvell.com \
--cc=mstarovoitov@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox