Re: [PATCH V4 mlx5-next 00/15] Add support to get xmit slave

Maor Gottlieb
2020-04-22T12:56:33Z

On 4/22/2020 3:46 PM, Jiri Pirko wrote:
> Wed, Apr 22, 2020 at 10:39:36AM CEST, maorg@mellanox.com wrote:
>
> [...]
>
>> Change log:
>> v4: 1. Rename master_get_xmit_slave to netdev_get_xmit_slave and move the implementation to dev.c
>> 2. Remove unnecessary check of NULL pointer.
>> 3. Fix typo.
> It is really hard to follow the changes if you don't have the changelog
> per patch. Could you have it per patch next time please?

Sure.
>
>
>> v3: 1. Move master_get_xmit_slave to netdevice.h and change the flags arg.
>> to bool.
>> 2. Split helper functions commit to multiple commits for each bond
>> mode.
>> 3. Extract refcotring changes to seperate commits.
>> v2: The first patch wasn't sent in v1.
>> v1: https://lore.kernel.org/netdev/ac373456-b838-29cf-645f-b1ea1a93e3b0@gmail.com/T/#t
>>