From: David Miller <davem@davemloft.net>
To: fgont@si6networks.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: Implement draft-ietf-6man-rfc4941bis
Date: Thu, 23 Apr 2020 12:26:40 -0700 (PDT) [thread overview]
Message-ID: <20200423.122640.181542852051859304.davem@davemloft.net> (raw)
In-Reply-To: <20200419121658.GA765@archlinux-current.localdomain>
From: Fernando Gont <fgont@si6networks.com>
Date: Sun, 19 Apr 2020 09:16:58 -0300
> @@ -1306,12 +1304,11 @@ static void ipv6_del_addr(struct inet6_ifaddr *ifp)
> in6_ifa_put(ifp);
> }
>
> -static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp,
> - struct inet6_ifaddr *ift,
> - bool block)
> +static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block)
> {
> struct inet6_dev *idev = ifp->idev;
> - struct in6_addr addr, *tmpaddr;
> + struct in6_addr addr;
> + struct inet6_ifaddr *ift;
> unsigned long tmp_tstamp, age;
> unsigned long regen_advance;
> struct ifa6_config cfg;
Please preserve the reverse christmas tree ordering of local variables
here.
Thank you.
prev parent reply other threads:[~2020-04-23 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 12:16 [PATCH net-next] ipv6: Implement draft-ietf-6man-rfc4941bis Fernando Gont
2020-04-23 19:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423.122640.181542852051859304.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fgont@si6networks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).