From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
ruxandra.radulescu@nxp.com, ioana.ciornei@nxp.com,
nipun.gupta@nxp.com, shawnguo@kernel.org, brouer@redhat.com
Subject: Re: [PATCH net-next 2/2] dpaa2-eth: fix return codes used in ndo_setup_tc
Date: Thu, 23 Apr 2020 17:38:04 +0200 [thread overview]
Message-ID: <20200423173804.004fd0f6@carbon> (raw)
In-Reply-To: <20200423082804.6235b084@hermes.lan>
On Thu, 23 Apr 2020 08:28:58 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> On Thu, 23 Apr 2020 16:57:50 +0200
> Jesper Dangaard Brouer <brouer@redhat.com> wrote:
>
> > Drivers ndo_setup_tc call should return -EOPNOTSUPP, when it cannot
> > support the qdisc type. Other return values will result in failing the
> > qdisc setup. This lead to qdisc noop getting assigned, which will
> > drop all TX packets on the interface.
> >
> > Fixes: ab1e6de2bd49 ("dpaa2-eth: Add mqprio support")
> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
>
> Would it be possible to use extack as well?
That is what patch 1/2 already does.
> Putting errors in dmesg is unhelpful
This patchset does not introduce any dmesg printk.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-04-23 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 14:57 [PATCH net-next 0/2] Fix qdisc noop issue caused by driver and identify future bugs Jesper Dangaard Brouer
2020-04-23 14:57 ` [PATCH net-next 1/2] net: sched: report ndo_setup_tc failures via extack Jesper Dangaard Brouer
2020-04-23 19:51 ` Ioana Ciornei
2020-04-23 14:57 ` [PATCH net-next 2/2] dpaa2-eth: fix return codes used in ndo_setup_tc Jesper Dangaard Brouer
2020-04-23 15:28 ` Stephen Hemminger
2020-04-23 15:38 ` Jesper Dangaard Brouer [this message]
2020-04-23 19:33 ` Stephen Hemminger
2020-04-23 19:56 ` Jakub Kicinski
2020-04-24 7:04 ` Jesper Dangaard Brouer
2020-04-25 0:28 ` Jakub Kicinski
2020-04-27 14:18 ` Marcelo Ricardo Leitner
2020-04-23 19:49 ` Ioana Ciornei
2020-04-24 23:45 ` [PATCH net-next 0/2] Fix qdisc noop issue caused by driver and identify future bugs David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423173804.004fd0f6@carbon \
--to=brouer@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=nipun.gupta@nxp.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=shawnguo@kernel.org \
--cc=stephen@networkplumber.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).