From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B832BC54FCB for ; Fri, 24 Apr 2020 12:27:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F15E20767 for ; Fri, 24 Apr 2020 12:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587731251; bh=fZ0I+VOnV8QwClZ+2y5zao6blmZkFeQHWhqW6QUCWjM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=aNtOM/n+KQni6h5O4R1fECGAsqAfGeBHjTkqY20uaYGLJkcckcfDWQsFpky0xdyAS A++dA0q5caWsG1dBshNIyjBWHqWkmxfCKGUgsc8OyyLONlFSpMAxDa3+I00MNQyYdh RNeuHXcsQH/3sgEbgnq2j5obpKldt0J89I+41cCY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728789AbgDXM1Y (ORCPT ); Fri, 24 Apr 2020 08:27:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:55266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728460AbgDXMYd (ORCPT ); Fri, 24 Apr 2020 08:24:33 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D52EF2168B; Fri, 24 Apr 2020 12:24:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587731073; bh=fZ0I+VOnV8QwClZ+2y5zao6blmZkFeQHWhqW6QUCWjM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BZrhTzaqJ1S85Ju0uWZoGJVuKzqE2YimgaZSP1kqKxjpru+JKFvBcTfu3cuOgGaQz S1rXxAsilLg4PxRlYLkcDMikV9I81CXo9OdwVEGmikVBzIOfIDgm/EKvjGVd1LREhB wFdqrSxrtg3hs3Qh/LgDyUMpVjUOCP5iFrpYu+DA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jason Gunthorpe , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 11/21] net/cxgb4: Check the return from t4_query_params properly Date: Fri, 24 Apr 2020 08:24:09 -0400 Message-Id: <20200424122419.10648-11-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200424122419.10648-1-sashal@kernel.org> References: <20200424122419.10648-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jason Gunthorpe [ Upstream commit c799fca8baf18d1bbbbad6c3b736eefbde8bdb90 ] Positive return values are also failures that don't set val, although this probably can't happen. Fixes gcc 10 warning: drivers/net/ethernet/chelsio/cxgb4/t4_hw.c: In function ‘t4_phy_fw_ver’: drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3747:14: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] 3747 | *phy_fw_ver = val; Fixes: 01b6961410b7 ("cxgb4: Add PHY firmware support for T420-BT cards") Signed-off-by: Jason Gunthorpe Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index 39bcf27902e4b..0f126ce4645f3 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c @@ -3609,7 +3609,7 @@ int t4_phy_fw_ver(struct adapter *adap, int *phy_fw_ver) FW_PARAMS_PARAM_Z_V(FW_PARAMS_PARAM_DEV_PHYFW_VERSION)); ret = t4_query_params(adap, adap->mbox, adap->pf, 0, 1, ¶m, &val); - if (ret < 0) + if (ret) return ret; *phy_fw_ver = val; return 0; -- 2.20.1