* [PATCH -next] net: phy: dp83867: Remove unneeded semicolon
@ 2020-04-24 9:08 Zheng Bin
2020-04-24 13:33 ` Andrew Lunn
2020-04-26 3:36 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Zheng Bin @ 2020-04-24 9:08 UTC (permalink / raw)
To: andrew, f.fainelli, hkallweit1, davem, netdev; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/net/phy/dp83867.c:368:2-3: Unneeded semicolon
drivers/net/phy/dp83867.c:403:2-3: Unneeded semicolon
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/phy/dp83867.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index b55e3c0403ed..4017ae1692d8 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -365,7 +365,7 @@ static int dp83867_get_downshift(struct phy_device *phydev, u8 *data)
break;
default:
return -EINVAL;
- };
+ }
*data = enable ? count : DOWNSHIFT_DEV_DISABLE;
@@ -400,7 +400,7 @@ static int dp83867_set_downshift(struct phy_device *phydev, u8 cnt)
phydev_err(phydev,
"Downshift count must be 1, 2, 4 or 8\n");
return -EINVAL;
- };
+ }
val = DP83867_DOWNSHIFT_EN;
val |= FIELD_PREP(DP83867_DOWNSHIFT_ATTEMPT_MASK, count);
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: phy: dp83867: Remove unneeded semicolon
2020-04-24 9:08 [PATCH -next] net: phy: dp83867: Remove unneeded semicolon Zheng Bin
@ 2020-04-24 13:33 ` Andrew Lunn
2020-04-26 3:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-04-24 13:33 UTC (permalink / raw)
To: Zheng Bin; +Cc: f.fainelli, hkallweit1, davem, netdev
On Fri, Apr 24, 2020 at 05:08:50PM +0800, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/phy/dp83867.c:368:2-3: Unneeded semicolon
> drivers/net/phy/dp83867.c:403:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: phy: dp83867: Remove unneeded semicolon
2020-04-24 9:08 [PATCH -next] net: phy: dp83867: Remove unneeded semicolon Zheng Bin
2020-04-24 13:33 ` Andrew Lunn
@ 2020-04-26 3:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-04-26 3:36 UTC (permalink / raw)
To: zhengbin13; +Cc: andrew, f.fainelli, hkallweit1, netdev
From: Zheng Bin <zhengbin13@huawei.com>
Date: Fri, 24 Apr 2020 17:08:50 +0800
> Fixes coccicheck warning:
>
> drivers/net/phy/dp83867.c:368:2-3: Unneeded semicolon
> drivers/net/phy/dp83867.c:403:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-26 3:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-24 9:08 [PATCH -next] net: phy: dp83867: Remove unneeded semicolon Zheng Bin
2020-04-24 13:33 ` Andrew Lunn
2020-04-26 3:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).