From: Jason Gunthorpe <jgg@mellanox.com>
To: Maor Gottlieb <maorg@mellanox.com>
Cc: davem@davemloft.net, dledford@redhat.com, j.vosburgh@gmail.com,
vfalico@gmail.com, andy@greyhouse.net, kuba@kernel.org,
jiri@mellanox.com, dsahern@kernel.org, leonro@mellanox.com,
saeedm@mellanox.com, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, alexr@mellanox.com
Subject: Re: [PATCH V5 mlx5-next 10/16] RDMA: Group create AH arguments in struct
Date: Sat, 25 Apr 2020 19:40:43 -0300 [thread overview]
Message-ID: <20200425224043.GY13640@mellanox.com> (raw)
In-Reply-To: <20200423125555.21759-11-maorg@mellanox.com>
On Thu, Apr 23, 2020 at 03:55:49PM +0300, Maor Gottlieb wrote:
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index bbc5cfb57cd2..c49e4d9ead66 100644
> +++ b/include/rdma/ib_verbs.h
> @@ -880,6 +880,12 @@ struct ib_mr_status {
> */
> __attribute_const__ enum ib_rate mult_to_ib_rate(int mult);
>
> +struct rdma_ah_init_attr {
> + struct rdma_ah_attr *ah_attr;
> + u32 flags;
> + struct ib_udata *udata;
I prefer to keep the udata as a function argument
Jason
next prev parent reply other threads:[~2020-04-25 22:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 12:55 [PATCH V5 mlx5-next 00/15] Add support to get xmit slave Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 01/16] net/core: Introduce netdev_get_xmit_slave Maor Gottlieb
2020-04-23 14:46 ` Jiri Pirko
2020-04-25 16:19 ` David Ahern
2020-04-23 12:55 ` [PATCH V5 mlx5-next 02/16] bonding: Export skip slave logic to function Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 03/16] bonding: Rename slave_arr to usable_slaves Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 04/16] bonding/alb: Add helper functions to get the xmit slave Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 05/16] bonding: Add helper function to get the xmit slave based on hash Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 06/16] bonding: Add helper function to get the xmit slave in rr mode Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 07/16] bonding: Add function to get the xmit slave in active-backup mode Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 08/16] bonding: Add array of all slaves Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 09/16] bonding: Implement ndo_get_xmit_slave Maor Gottlieb
2020-04-23 14:47 ` Jiri Pirko
2020-04-23 12:55 ` [PATCH V5 mlx5-next 10/16] RDMA: Group create AH arguments in struct Maor Gottlieb
2020-04-25 22:40 ` Jason Gunthorpe [this message]
2020-04-23 12:55 ` [PATCH V5 mlx5-next 11/16] RDMA/core: Add LAG functionality Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 12/16] RDMA/core: Get xmit slave for LAG Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 13/16] net/mlx5: Change lag mutex lock to spin lock Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 14/16] net/mlx5: Add support to get lag physical port Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 15/16] RDMA/mlx5: Refactor affinity related code Maor Gottlieb
2020-04-23 12:55 ` [PATCH V5 mlx5-next 16/16] RDMA/mlx5: Set lag tx affinity according to slave Maor Gottlieb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425224043.GY13640@mellanox.com \
--to=jgg@mellanox.com \
--cc=alexr@mellanox.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=dsahern@kernel.org \
--cc=j.vosburgh@gmail.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).