Re: [PATCH net-next v1 1/9] net: phy: Add cable test support to state machine

[Andrew Lunn <andrew@lunn.ch>]

> > +	mutex_lock(&phydev->lock);
> > +	if (phydev->state < PHY_UP ||
> > +	    phydev->state >= PHY_CABLETEST) {
> > +		NL_SET_ERR_MSG(extack,
> > +			       "PHY not configured. Try setting interface up");
> > +		err = -EBUSY;
> > +		goto out;
> > +	}
> 
> If I read the code correctly, this check would also catch an attempt to
> start a cable test while the test is already in progress in which case
> the error message would be rather misleading. I'm not sure what would be
> more appropriate in such case: we can return -EBUSY (with more fitting
> error message) but we could also silently ignore the request and let the
> client wait for the notification from the test which is already in
> progress.

Hi Michal

Yes, i will change this to handle phydev->state == PHY_CABLETEST
differently. Probably -EBUSY is the simplest.

Thanks
	Andrew