From: Stephen Hemminger <stephen@networkplumber.org>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Xiumei Mu <xmu@redhat.com>,
aclaudi@redhat.com
Subject: Re: [PATCH iproute2] xfrm: also check for ipv6 state in xfrm_state_keep
Date: Mon, 27 Apr 2020 18:15:09 -0700 [thread overview]
Message-ID: <20200427181509.3f408bbd@hermes.lan> (raw)
In-Reply-To: <a5e26e7eb3172c2ddebdc5b006f3afaf3e4adb5c.1587971664.git.lucien.xin@gmail.com>
On Mon, 27 Apr 2020 15:14:24 +0800
Xin Long <lucien.xin@gmail.com> wrote:
> As commit f9d696cf414c ("xfrm: not try to delete ipcomp states when using
> deleteall") does, this patch is to fix the same issue for ip6 state where
> xsinfo->id.proto == IPPROTO_IPV6.
>
> # ip xfrm state add src 2000::1 dst 2000::2 spi 0x1000 \
> proto comp comp deflate mode tunnel sel src 2000::1 dst \
> 2000::2 proto gre
> # ip xfrm sta deleteall
> Failed to send delete-all request
> : Operation not permitted
>
> Note that the xsinfo->proto in common states can never be IPPROTO_IPV6.
>
> Fixes: f9d696cf414c ("xfrm: not try to delete ipcomp states when using deleteall")
> Reported-by: Xiumei Mu <xmu@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied
prev parent reply other threads:[~2020-04-28 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 7:14 [PATCH iproute2] xfrm: also check for ipv6 state in xfrm_state_keep Xin Long
2020-04-27 14:48 ` Andrea Claudi
2020-04-28 1:15 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427181509.3f408bbd@hermes.lan \
--to=stephen@networkplumber.org \
--cc=aclaudi@redhat.com \
--cc=dsahern@gmail.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xmu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).