From: Dejin Zheng <zhengdejin5@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: tglx@linutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1] ethernet: ks8842: delete unnecessary goto label
Date: Tue, 28 Apr 2020 10:58:44 +0800 [thread overview]
Message-ID: <20200428025844.GA31933@nuc8i5> (raw)
In-Reply-To: <20200427.111547.346558310845161759.davem@davemloft.net>
On Mon, Apr 27, 2020 at 11:15:47AM -0700, David Miller wrote:
> From: Dejin Zheng <zhengdejin5@gmail.com>
> Date: Sat, 25 Apr 2020 19:56:12 +0800
>
> > the label of err_register is not necessary, so delete it to
> > simplify code.
> >
> > Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
>
> It's not unnecessary, it's documenting the state of the probe.
David, Thanks for your information, and abandon this commit.
BR,
Dejin
prev parent reply other threads:[~2020-04-28 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 11:56 [PATCH net-next v1] ethernet: ks8842: delete unnecessary goto label Dejin Zheng
2020-04-27 18:15 ` David Miller
2020-04-28 2:58 ` Dejin Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428025844.GA31933@nuc8i5 \
--to=zhengdejin5@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox