* [PATCH] ath5k: remove conversion to bool in ath5k_ani_calibration()
@ 2020-04-26 9:40 Jason Yan
2020-04-28 9:12 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-26 9:40 UTC (permalink / raw)
To: jirislaby, mickflemm, mcgrof, kvalo, davem, linux-wireless,
netdev, linux-kernel
Cc: Jason Yan
The '>' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:
drivers/net/wireless/ath/ath5k/ani.c:504:56-61: WARNING: conversion to
bool not needed here
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/net/wireless/ath/ath5k/ani.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath5k/ani.c b/drivers/net/wireless/ath/ath5k/ani.c
index 0624333f5430..850c608b43a3 100644
--- a/drivers/net/wireless/ath/ath5k/ani.c
+++ b/drivers/net/wireless/ath/ath5k/ani.c
@@ -501,7 +501,7 @@ ath5k_ani_calibration(struct ath5k_hw *ah)
if (as->ofdm_errors > ofdm_high || as->cck_errors > cck_high) {
/* too many PHY errors - we have to raise immunity */
- bool ofdm_flag = as->ofdm_errors > ofdm_high ? true : false;
+ bool ofdm_flag = as->ofdm_errors > ofdm_high;
ath5k_ani_raise_immunity(ah, as, ofdm_flag);
ath5k_ani_period_restart(as);
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ath5k: remove conversion to bool in ath5k_ani_calibration()
2020-04-26 9:40 [PATCH] ath5k: remove conversion to bool in ath5k_ani_calibration() Jason Yan
@ 2020-04-28 9:12 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-04-28 9:12 UTC (permalink / raw)
To: Jason Yan
Cc: jirislaby, mickflemm, mcgrof, davem, linux-wireless, netdev,
linux-kernel, Jason Yan
Jason Yan <yanaijie@huawei.com> wrote:
> The '>' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/net/wireless/ath/ath5k/ani.c:504:56-61: WARNING: conversion to
> bool not needed here
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
c26b01d5ec1a ath5k: remove conversion to bool in ath5k_ani_calibration()
--
https://patchwork.kernel.org/patch/11510327/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-28 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-26 9:40 [PATCH] ath5k: remove conversion to bool in ath5k_ani_calibration() Jason Yan
2020-04-28 9:12 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).