From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
linux-stm32@st-md-mailman.stormreply.com,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 1/5] stmmac: intel: Check return value of clk_prepare_enable()
Date: Wed, 29 Apr 2020 17:22:52 +0300 [thread overview]
Message-ID: <20200429142252.GK185537@smile.fi.intel.com> (raw)
In-Reply-To: <20200429140449.9484-1-andriy.shevchenko@linux.intel.com>
On Wed, Apr 29, 2020 at 05:04:45PM +0300, Andy Shevchenko wrote:
> clk_prepare_enable() might fail, we have to check its returned value.
>
> While at it, remove leftover in stmmac_pci, also remove unneeded condition
> for NULL-aware clk_unregister_fixed_rate() call and call it when
> stmmac_dvr_probe() fails.
Please, ignore this series. It appears that there is one more issue with proper
error handling. I'll send v2 soon after additional testing.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-29 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 14:04 [PATCH v1 1/5] stmmac: intel: Check return value of clk_prepare_enable() Andy Shevchenko
2020-04-29 14:04 ` [PATCH v1 2/5] stmmac: intel: Remove unnecessary loop for PCI BARs Andy Shevchenko
2020-04-29 14:04 ` [PATCH v1 3/5] stmmac: intel: Convert to use pci_alloc_irq_vectors() API Andy Shevchenko
2020-04-29 14:04 ` [PATCH v1 4/5] stmmac: intel: Eliminate useless conditions and variables Andy Shevchenko
2020-04-29 14:04 ` [PATCH v1 5/5] stmmac: intel: Fix indentation to put on one line affected code Andy Shevchenko
2020-04-29 14:22 ` Andy Shevchenko [this message]
2020-04-29 19:13 ` [PATCH v1 1/5] stmmac: intel: Check return value of clk_prepare_enable() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429142252.GK185537@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).