From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3019C83004 for ; Wed, 29 Apr 2020 14:22:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDAC8206F0 for ; Wed, 29 Apr 2020 14:22:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727934AbgD2OWx (ORCPT ); Wed, 29 Apr 2020 10:22:53 -0400 Received: from mga02.intel.com ([134.134.136.20]:2447 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbgD2OWw (ORCPT ); Wed, 29 Apr 2020 10:22:52 -0400 IronPort-SDR: ddIyjzvcB8w0uI64c2EH6wT5U6HAzdX8pFnDzATEN9YpqFwMK06TJMDvyQ99K4hpNFf6XvRbZn 6Ox1T/fxpvxQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 07:22:51 -0700 IronPort-SDR: LewOahKZhx0sn+cAkxy5DPIPD5ioJPKN91mYfHiyAhJgNQqzdLT3xtPMdU0LITnlc0fXmK3I9L Ll8ufsaZ0K/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,332,1583222400"; d="scan'208";a="293215157" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002.fm.intel.com with ESMTP; 29 Apr 2020 07:22:49 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jTnbw-003jji-Bu; Wed, 29 Apr 2020 17:22:52 +0300 Date: Wed, 29 Apr 2020 17:22:52 +0300 From: Andy Shevchenko To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , linux-stm32@st-md-mailman.stormreply.com, "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH v1 1/5] stmmac: intel: Check return value of clk_prepare_enable() Message-ID: <20200429142252.GK185537@smile.fi.intel.com> References: <20200429140449.9484-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429140449.9484-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 29, 2020 at 05:04:45PM +0300, Andy Shevchenko wrote: > clk_prepare_enable() might fail, we have to check its returned value. > > While at it, remove leftover in stmmac_pci, also remove unneeded condition > for NULL-aware clk_unregister_fixed_rate() call and call it when > stmmac_dvr_probe() fails. Please, ignore this series. It appears that there is one more issue with proper error handling. I'll send v2 soon after additional testing. -- With Best Regards, Andy Shevchenko