From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com,
jacob.e.keller@intel.com, parav@mellanox.com
Subject: Re: [PATCH net] devlink: fix return value after hitting end in region read
Date: Wed, 29 Apr 2020 17:47:24 +0200 [thread overview]
Message-ID: <20200429154724.GD6581@nanopsycho.orion> (raw)
In-Reply-To: <20200429020158.988886-1-kuba@kernel.org>
Wed, Apr 29, 2020 at 04:01:58AM CEST, kuba@kernel.org wrote:
>Commit d5b90e99e1d5 ("devlink: report 0 after hitting end in region read")
>fixed region dump, but region read still returns a spurious error:
>
>$ devlink region read netdevsim/netdevsim1/dummy snapshot 0 addr 0 len 128
>0000000000000000 a6 f4 c4 1c 21 35 95 a6 9d 34 c3 5b 87 5b 35 79
>0000000000000010 f3 a0 d7 ee 4f 2f 82 7f c6 dd c4 f6 a5 c3 1b ae
>0000000000000020 a4 fd c8 62 07 59 48 03 70 3b c7 09 86 88 7f 68
>0000000000000030 6f 45 5d 6d 7d 0e 16 38 a9 d0 7a 4b 1e 1e 2e a6
>0000000000000040 e6 1d ae 06 d6 18 00 85 ca 62 e8 7e 11 7e f6 0f
>0000000000000050 79 7e f7 0f f3 94 68 bd e6 40 22 85 b6 be 6f b1
>0000000000000060 af db ef 5e 34 f0 98 4b 62 9a e3 1b 8b 93 fc 17
>devlink answers: Invalid argument
>0000000000000070 61 e8 11 11 66 10 a5 f7 b1 ea 8d 40 60 53 ed 12
>
>This is a minimal fix, I'll follow up with a restructuring
>so we don't have two checks for the same condition.
>
>Fixes: fdd41ec21e15 ("devlink: Return right error code in case of errors for region read")
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
prev parent reply other threads:[~2020-04-29 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 2:01 [PATCH net] devlink: fix return value after hitting end in region read Jakub Kicinski
2020-04-29 15:11 ` Keller, Jacob E
2020-04-29 15:47 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429154724.GD6581@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox