From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D28C4724C for ; Thu, 30 Apr 2020 15:56:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A2F92076D for ; Thu, 30 Apr 2020 15:56:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="sbfh3p4t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726550AbgD3P4v (ORCPT ); Thu, 30 Apr 2020 11:56:51 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:49511 "EHLO wout5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgD3P4u (ORCPT ); Thu, 30 Apr 2020 11:56:50 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id C93BB86F; Thu, 30 Apr 2020 11:56:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 30 Apr 2020 11:56:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=3RpLzR AZmoGsH5/njPn/0R69Z0vhJrHObhLFL6joNtg=; b=sbfh3p4t8AsArW+k8FG0o3 da1kQbKW6t0TNVXhiq9T8xqMUTNAsJsFM36/B+fVsqhoCRc/qTC0pUUHhxMAzzi0 HZs9xXNy56d0uSrW8GUewTiFeWO7Q9uwgiBsZv9e3YAfXKnmGaZotn6s+h6gI4w5 efU5QKB2ModJQlXUM0xxXQaA1rSe/85yKr45f6q+EQ+S/CZS7RBuiQLRHkbkL8Bd RW+/BzWDgxUIyntFgoUCWrIvxytJ7x/LkX3S+wD9tmlk4LAJ3ONf7lHHb0ULQSHN YtdYG2IwdDGnuNjgD+bebRvntYbApo2axkATJXNQLld4J4kvBX4qCUb5vZMsx/rQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieehgdelgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcuufgt hhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrthhtvg hrnheptdffkeekfeduffevgeeujeffjefhtefgueeugfevtdeiheduueeukefhudehleet necukfhppeejledrudektddrheegrdduudeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: from localhost (bzq-79-180-54-116.red.bezeqint.net [79.180.54.116]) by mail.messagingengine.com (Postfix) with ESMTPA id 74C3B3280060; Thu, 30 Apr 2020 11:56:48 -0400 (EDT) Date: Thu, 30 Apr 2020 18:56:45 +0300 From: Ido Schimmel To: Nikolay Aleksandrov Cc: Stefan Priebe - Profihost AG , roopa@cumulusnetworks.com, davem@davemloft.net, "bridge@lists.linux-foundation.org" , netdev@vger.kernel.org Subject: Re: BUG: soft lockup while deleting tap interface from vlan aware bridge Message-ID: <20200430155645.GA4076599@splinter> References: <85b1e301-8189-540b-b4bf-d0902e74becc@profihost.ag> <20200430105551.GA4068275@splinter> <4b3a6079-d8d4-24c5-8fc9-15bcb96bca80@cumulusnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b3a6079-d8d4-24c5-8fc9-15bcb96bca80@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 30, 2020 at 02:20:23PM +0300, Nikolay Aleksandrov wrote: > Maybe we can batch the deletes at say 32 at a time? Hi Nik, Thanks for looking into this! I don't really feel comfortable hard coding an arbitrary number of entries before calling cond_resched(). I didn't see a noticeable difference in execution time with the previous patch versus an unpatched kernel. Also, in the examples I saw in the networking code cond_resched() is always called after each loop iteration. Let me know how you prefer it and I will send a patch.