From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 272F9C4724C for ; Thu, 30 Apr 2020 19:41:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E87AD2073E for ; Thu, 30 Apr 2020 19:41:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="20TN8wWq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726420AbgD3Tls (ORCPT ); Thu, 30 Apr 2020 15:41:48 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:34842 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgD3Tlr (ORCPT ); Thu, 30 Apr 2020 15:41:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/yKT0kEu0twZ55Af42Shn8uTiSBnYYF/fmHd0lOTNu8=; b=20TN8wWq68SkMxcx43cLgoBSqs NMkSQUz6/2gFa2gCfR+AzLjdDJm0KZoACfixK1X1pn65gutZEHfHSgj+IrlahTNUvtR8Iku0DRqWF odLlJb8q3C+hg0ym5qDGUOOxSC2TOjP8fuKwMuuzXZhlae70MpVSNlNOZ1gDWm1Eh2Ns=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jUF43-000SJk-VA; Thu, 30 Apr 2020 21:41:43 +0200 Date: Thu, 30 Apr 2020 21:41:43 +0200 From: Andrew Lunn To: Michael Walle Cc: Florian Fainelli , cphealy@gmail.com, davem@davemloft.net, hkallweit1@gmail.com, mkubecek@suse.cz, netdev@vger.kernel.org Subject: Re: [PATCH net-next v1 0/9] Ethernet Cable test support Message-ID: <20200430194143.GF107658@lunn.ch> References: <20200425180621.1140452-1-andrew@lunn.ch> <20200429160213.21777-1-michael@walle.cc> <20200429163247.GC66424@lunn.ch> <61eb35f8-3264-117d-59c2-22f0fdc36e96@gmail.com> <9caef9bbfaed5c75e72e083db8a552fd@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9caef9bbfaed5c75e72e083db8a552fd@walle.cc> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > ECD. The registers looks exactly like the one from the Marvell PHYs, > which makes me wonder if both have the same building block or if one > imitated the registers of the other. There are subtle differences > like one bit in the broadcom PHY is "break link" and is self-clearing, > while the bit on the Marvell PHY is described as "perform diagnostics > on link break". Should we be sharing code between the two drivers? > What do you mean by calibrate it? Some of the Marvell documentation talks about calibrating for losses on the PCB. Run a diagnostics with no cable plugged in, and get the cable length to the 'fault'. This gives you the distance to the RJ45 socket. You should then subtract that from all subsequent results. But since this is board design specific, i decided to ignore it. I suppose it could be stuffed into a DT property, but i got the feeling it is not worth it, given the measurement granularity of 80cm. Andrew