From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5F2C47256 for ; Fri, 1 May 2020 22:20:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FEB6208DB for ; Fri, 1 May 2020 22:20:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726449AbgEAWUR (ORCPT ); Fri, 1 May 2020 18:20:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726318AbgEAWUR (ORCPT ); Fri, 1 May 2020 18:20:17 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F3BEC061A0C for ; Fri, 1 May 2020 15:20:17 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A9E5314F2D944; Fri, 1 May 2020 15:20:16 -0700 (PDT) Date: Fri, 01 May 2020 15:20:15 -0700 (PDT) Message-Id: <20200501.152015.1993781585716424031.davem@davemloft.net> To: brouer@redhat.com Cc: netdev@vger.kernel.org, me@tobin.cc Subject: Re: [PATCH net-next] net: fix skb_panic to output real address From: David Miller In-Reply-To: <158800546361.1962096.4535216438507756179.stgit@firesoul> References: <158800546361.1962096.4535216438507756179.stgit@firesoul> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 01 May 2020 15:20:16 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jesper Dangaard Brouer Date: Mon, 27 Apr 2020 18:37:43 +0200 > In skb_panic() the real pointer values are really needed to diagnose > issues, e.g. data and head are related (to calculate headroom). The > hashed versions of the addresses doesn't make much sense here. The > patch use the printk specifier %px to print the actual address. > > The printk documentation on %px: > https://www.kernel.org/doc/html/latest/core-api/printk-formats.html#unmodified-addresses > > Fixes: ad67b74d2469 ("printk: hash addresses printed with %p") > Signed-off-by: Jesper Dangaard Brouer Applied.