From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F13C47247 for ; Fri, 1 May 2020 00:01:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE34720873 for ; Fri, 1 May 2020 00:01:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="S/lpXOL2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727896AbgEAABd (ORCPT ); Thu, 30 Apr 2020 20:01:33 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35378 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726384AbgEAABc (ORCPT ); Thu, 30 Apr 2020 20:01:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dQJZqv0jbv8xJipHeV964cSitXyw0u38aI2IjcFctcg=; b=S/lpXOL2loivCVqVHYJrQr0EHp QgpZTNRwSmTxzesaGFAK2RPu3COj+YrWHD48+2K1p01kRruyU0geAvv1te3K0ZgUivfNrMlsYUBAW 5gyteqBVPDc9kEFGeP4vuk7NK/XXgXR5vmV/kHp1E5PV5S5+kOPY+6lTtSxEA3SeI34Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jUJ7P-000U6j-0M; Fri, 01 May 2020 02:01:27 +0200 Date: Fri, 1 May 2020 02:01:26 +0200 From: Andrew Lunn To: Vadym Kochan Cc: netdev@vger.kernel.org, "David S. Miller" , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , Andrii Savka , Jiri Pirko , Ido Schimmel , Chris Packham Subject: Re: [RFC next-next v2 5/5] dt-bindings: marvell,prestera: Add address mapping for Prestera Switchdev PCIe driver Message-ID: <20200501000126.GD22077@lunn.ch> References: <20200430232052.9016-1-vadym.kochan@plvision.eu> <20200430232052.9016-6-vadym.kochan@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430232052.9016-6-vadym.kochan@plvision.eu> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 01, 2020 at 02:20:52AM +0300, Vadym Kochan wrote: > Document requirement for the PCI port which is connected to the ASIC, to > allow access to the firmware related registers. > > Signed-off-by: Vadym Kochan > --- > .../devicetree/bindings/net/marvell,prestera.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/marvell,prestera.txt b/Documentation/devicetree/bindings/net/marvell,prestera.txt > index 83370ebf5b89..103c35cfa8a7 100644 > --- a/Documentation/devicetree/bindings/net/marvell,prestera.txt > +++ b/Documentation/devicetree/bindings/net/marvell,prestera.txt > @@ -45,3 +45,16 @@ dfx-server { > ranges = <0 MBUS_ID(0x08, 0x00) 0 0x100000>; > reg = ; > }; > + > +Marvell Prestera SwitchDev bindings > +----------------------------------- > +The current implementation of Prestera Switchdev PCI interface driver requires > +that BAR2 is assigned to 0xf6000000 as base address from the PCI IO range: > + > +&cp0_pcie0 { > + ranges = <0x81000000 0x0 0xfb000000 0x0 0xfb000000 0x0 0xf0000 > + 0x82000000 0x0 0xf6000000 0x0 0xf6000000 0x0 0x2000000 > + 0x82000000 0x0 0xf9000000 0x0 0xf9000000 0x0 0x100000>; > + phys = <&cp0_comphy0 0>; > + status = "okay"; The base MAC address should be here as well. As was said for v1, module parameters are bad. Andrew