From: Martin KaFai Lau <kafai@fb.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<davem@davemloft.net>, <ast@kernel.org>, <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCH bpf-next v3] bpf: bpf_{g,s}etsockopt for struct bpf_sock_addr
Date: Thu, 30 Apr 2020 22:54:35 -0700 [thread overview]
Message-ID: <20200501055435.lfqqn2sprwclw2fa@kafai-mbp> (raw)
In-Reply-To: <20200430233152.199403-1-sdf@google.com>
On Thu, Apr 30, 2020 at 04:31:52PM -0700, Stanislav Fomichev wrote:
> Currently, bpf_getsockopt and bpf_setsockopt helpers operate on the
> 'struct bpf_sock_ops' context in BPF_PROG_TYPE_SOCK_OPS program.
> Let's generalize them and make them available for 'struct bpf_sock_addr'.
> That way, in the future, we can allow those helpers in more places.
>
> As an example, let's expose those 'struct bpf_sock_addr' based helpers to
> BPF_CGROUP_INET{4,6}_CONNECT hooks. That way we can override CC before the
> connection is made.
>
> v3:
> * Expose custom helpers for bpf_sock_addr context instead of doing
> generic bpf_sock argument (as suggested by Daniel). Even with
> try_socket_lock that doesn't sleep we have a problem where context sk
> is already locked and socket lock is non-nestable.
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2020-05-01 5:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 23:31 [PATCH bpf-next v3] bpf: bpf_{g,s}etsockopt for struct bpf_sock_addr Stanislav Fomichev
2020-05-01 5:54 ` Martin KaFai Lau [this message]
2020-05-01 18:33 ` John Fastabend
2020-05-01 19:53 ` Alexei Starovoitov
2020-05-01 21:52 ` Andrey Ignatov
2020-05-01 22:07 ` Stanislav Fomichev
2020-05-01 22:16 ` Andrey Ignatov
2020-05-01 22:29 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501055435.lfqqn2sprwclw2fa@kafai-mbp \
--to=kafai@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox