From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net, jiri@resnulli.us
Cc: netdev@vger.kernel.org, kernel-team@fb.com,
jacob.e.keller@intel.com, Jakub Kicinski <kuba@kernel.org>,
Jiri Pirko <jiri@mellanox.com>
Subject: [PATCH net-next v4 3/3] docs: devlink: clarify the scope of snapshot id
Date: Fri, 1 May 2020 09:40:42 -0700 [thread overview]
Message-ID: <20200501164042.1430604-4-kuba@kernel.org> (raw)
In-Reply-To: <20200501164042.1430604-1-kuba@kernel.org>
In past discussions Jiri explained snapshot ids are cross-region.
Explain this in the docs.
v3: new patch
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
---
Documentation/networking/devlink/devlink-region.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/networking/devlink/devlink-region.rst b/Documentation/networking/devlink/devlink-region.rst
index daf35427fce1..3654c3e9658f 100644
--- a/Documentation/networking/devlink/devlink-region.rst
+++ b/Documentation/networking/devlink/devlink-region.rst
@@ -14,6 +14,10 @@ Region snapshots are collected by the driver, and can be accessed via read
or dump commands. This allows future analysis on the created snapshots.
Regions may optionally support triggering snapshots on demand.
+Snapshot identifiers are scoped to the devlink instance, not a region.
+All snapshots with the same snapshot id within a devlink instance
+correspond to the same event.
+
The major benefit to creating a region is to provide access to internal
address regions that are otherwise inaccessible to the user.
--
2.25.4
next prev parent reply other threads:[~2020-05-01 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 16:40 [PATCH net-next v4 0/3] devlink: kernel region snapshot id allocation Jakub Kicinski
2020-05-01 16:40 ` [PATCH net-next v4 1/3] devlink: factor out building a snapshot notification Jakub Kicinski
2020-05-01 21:35 ` Jacob Keller
2020-05-01 16:40 ` [PATCH net-next v4 2/3] devlink: let kernel allocate region snapshot id Jakub Kicinski
2020-05-01 21:36 ` Jacob Keller
2020-05-01 16:40 ` Jakub Kicinski [this message]
2020-05-04 18:58 ` [PATCH net-next v4 0/3] devlink: kernel region snapshot id allocation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501164042.1430604-4-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).