From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CFCAC47247 for ; Mon, 4 May 2020 09:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BCAF2078C for ; Mon, 4 May 2020 09:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="sR0r3BFK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728568AbgEDJuz (ORCPT ); Mon, 4 May 2020 05:50:55 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:42216 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728427AbgEDJuy (ORCPT ); Mon, 4 May 2020 05:50:54 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588585854; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=dsoB2pXtHXtJ6z6FYDGExSBwxV7fxuDgwhHrrM4FK4Y=; b=sR0r3BFKKPUoqLWumWZz/sPeJhI96b6KGedBnpGBZzphPpTkLc/GIcteTZI/yld2Yo2q3CyW 6Jx3OUrRgnHOFXubx3ML/pO5alZUTKAx9zuQ/5k8Th5pv8H8Ja67tPHl1h+5p5AEKwObTqZQ 7j2wAqptEw2Kt1jSaKNQa6R7QDE= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5eafe572.7f7a1c2c67d8-smtp-out-n03; Mon, 04 May 2020 09:50:42 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4289CC432C2; Mon, 4 May 2020 09:50:42 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id E6E97C433CB; Mon, 4 May 2020 09:50:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E6E97C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] brcmfmac: no need to check return value of debugfs_create functions From: Kalle Valo In-Reply-To: <20200429101526.GA2094124@kroah.com> References: <20200429101526.GA2094124@kroah.com> To: Greg Kroah-Hartman Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S. Miller" , Pieter-Paul Giesberts , Greg Kroah-Hartman , =?utf-8?b?UmFmYcWCIE1pxYJl?= =?utf-8?b?Y2tp?= , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200504095042.4289CC432C2@smtp.codeaurora.org> Date: Mon, 4 May 2020 09:50:42 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > In doing this, make brcmf_debugfs_add_entry() return void as no one was > even paying attention to the return value. > > Cc: Arend van Spriel > Cc: Franky Lin > Cc: Hante Meuleman > Cc: Chi-Hsien Lin > Cc: Wright Feng > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Pieter-Paul Giesberts > Cc: Greg Kroah-Hartman > Cc: "Rafał Miłecki" > Cc: linux-wireless@vger.kernel.org > Cc: brcm80211-dev-list.pdl@broadcom.com > Cc: brcm80211-dev-list@cypress.com > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > Acked-by: Arend van Spriel Patch applied to wireless-drivers-next.git, thanks. ea1b3bc6d5ad brcmfmac: no need to check return value of debugfs_create functions -- https://patchwork.kernel.org/patch/11516617/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches