From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A8BC47256 for ; Tue, 5 May 2020 07:45:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63E7F21744 for ; Tue, 5 May 2020 07:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588664720; bh=d7kGl8EmDAO8ZOBK3gZ//gfpMqkW08L56eEq7FgxXWk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JkAFv94YWWKsFKXYlnRLRUq421bR3R5fqGAlQdsqDpo/rkp+vKR6UUg5Ma/Dyols4 xeVkrvklWcmoMcQUQH7iuhcaMZ2LJmEDMvmSJAAy5HMdr1jyTZXmyO1fBW28ShBMs+ QOMNcoB+vartQsGTJY4d5q+1hFLh5M9PtH90ElXI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728579AbgEEHpS (ORCPT ); Tue, 5 May 2020 03:45:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:40562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728565AbgEEHpP (ORCPT ); Tue, 5 May 2020 03:45:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 179002078E; Tue, 5 May 2020 07:45:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588664715; bh=d7kGl8EmDAO8ZOBK3gZ//gfpMqkW08L56eEq7FgxXWk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z0SS3n1fnEgyhA06l2/QuLbQ0/QDNt18elj+gWpCVRwcrNus8vy9DwuClxJ8pB5gN nVSOdJNcaOsnEkF6q8yzqVNMnpvt1OvDrqolEqWgfMUYAYfuFKgZs+csxtkDVrngjr VSEpbaFdvLuaCleSmCj/4VMCust8N+VB3s9QcZpI= Date: Tue, 5 May 2020 09:45:11 +0200 From: Greg KH To: SeongJae Park Cc: davem@davemloft.net, viro@zeniv.linux.org.uk, kuba@kernel.org, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: Re: [PATCH net 1/2] Revert "coallocate socket_wq with socket itself" Message-ID: <20200505074511.GA4054974@kroah.com> References: <20200505072841.25365-1-sjpark@amazon.com> <20200505072841.25365-2-sjpark@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505072841.25365-2-sjpark@amazon.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, May 05, 2020 at 09:28:40AM +0200, SeongJae Park wrote: > From: SeongJae Park > > This reverts commit 333f7909a8573145811c4ab7d8c9092301707721. > > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the > deallocation of 'socket_alloc' to be done asynchronously using RCU, as > same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate > socket_sq with socket itself") made those to have same life cycle. > > The changes made the code much more simple, but also made 'socket_alloc' > live longer than before. For the reason, user programs intensively > repeating allocations and deallocations of sockets could cause memory > pressure on recent kernels. > > To avoid the problem, this commit separates the life cycle of > 'socket_alloc' and 'sock.wq' again. The following commit will make the > deallocation of 'socket_alloc' to be done synchronously again. > --- No signed-off-by? No "Fixes:"? :(