netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sjpark@amazon.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: SeongJae Park <sjpark@amazon.com>, <davem@davemloft.net>,
	<viro@zeniv.linux.org.uk>, <kuba@kernel.org>,
	<edumazet@google.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, SeongJae Park <sjpark@amazon.de>
Subject: Re: Re: [PATCH net 2/2] Revert "sockfs: switch to ->free_inode()"
Date: Tue, 5 May 2020 10:09:23 +0200	[thread overview]
Message-ID: <20200505080923.6970-1-sjpark@amazon.com> (raw)
In-Reply-To: <20200505074535.GB4054974@kroah.com> (raw)

On Tue, 5 May 2020 09:45:35 +0200 Greg KH <gregkh@linuxfoundation.org> wrote:

> On Tue, May 05, 2020 at 09:28:41AM +0200, SeongJae Park wrote:
> > From: SeongJae Park <sjpark@amazon.de>
> > 
> > This reverts commit 6d7855c54e1e269275d7c504f8f62a0b7a5b3f18.
> > 
> > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
> > deallocation of 'socket_alloc' to be done asynchronously using RCU, as
> > same to 'sock.wq'.
> > 
> > The change made 'socket_alloc' live longer than before.  As a result,
> > user programs intensively repeating allocations and deallocations of
> > sockets could cause memory pressure on recent kernels.
> > 
> > To avoid the problem, this commit reverts the change.
> > ---
> >  net/socket.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Same problems here as in patch 1/2 :(

Yes, indeed.  I will send next version right now.


Thanks,
SeongJae Park

> 

  reply	other threads:[~2020-05-05  8:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05  7:28 [PATCH net 0/2] Revert the 'socket_alloc' life cycle change SeongJae Park
2020-05-05  7:28 ` [PATCH net 1/2] Revert "coallocate socket_wq with socket itself" SeongJae Park
2020-05-05  7:45   ` Greg KH
2020-05-05  8:04     ` SeongJae Park
2020-05-05  7:28 ` [PATCH net 2/2] Revert "sockfs: switch to ->free_inode()" SeongJae Park
2020-05-05  7:45   ` Greg KH
2020-05-05  8:09     ` SeongJae Park [this message]
2020-05-05 12:44 ` [PATCH net 0/2] Revert the 'socket_alloc' life cycle change Al Viro
2020-05-05 14:24   ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200505080923.6970-1-sjpark@amazon.com \
    --to=sjpark@amazon.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sjpark@amazon.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).