From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46FF3C47247 for ; Tue, 5 May 2020 13:15:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04134206A5 for ; Tue, 5 May 2020 13:15:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="r5/hSQDU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729012AbgEENPw (ORCPT ); Tue, 5 May 2020 09:15:52 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:42416 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728497AbgEENPw (ORCPT ); Tue, 5 May 2020 09:15:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Yegq8+UTtwGex5/e4DboLkpznYHgZqhMOzbQZjh5Rzo=; b=r5/hSQDUJ9lwpseOXp1+nd5ByE zypzD+YbqEgd0xGNtbVmAPelfaGV+BD725A7vcbebP/669r94Iywaepyq9lL9L28SE4676iyglNFJ GvwRGFg67GDbEgRdEqYqZ3xjws7k8P7XufOhh+03v1w4R2mKuJkE+4xygUIBSHKkF7+c=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jVxQK-000w2Y-7y; Tue, 05 May 2020 15:15:48 +0200 Date: Tue, 5 May 2020 15:15:48 +0200 From: Andrew Lunn To: Michal Kubecek Cc: David Miller , netdev , Florian Fainelli , Heiner Kallweit , Chris Healy , michael@walle.cc Subject: Re: [PATCH net-next v2 04/10] net: ethtool: Add attributes for cable test reports Message-ID: <20200505131548.GE208718@lunn.ch> References: <20200505001821.208534-1-andrew@lunn.ch> <20200505001821.208534-5-andrew@lunn.ch> <20200505082838.GH8237@lion.mk-sys.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505082838.GH8237@lion.mk-sys.cz> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > + +---------------------------------------------+--------+---------------------+ > > + | ``ETHTOOL_A_CABLE_TEST_HEADER`` | nested | reply header | > > + +---------------------------------------------+--------+---------------------+ > > + | ``ETHTOOL_A_CABLE_TEST_STATUS`` | u8 | completed | > > + +---------------------------------------------+--------+---------------------+ > > + | ``ETHTOOL_A_CABLE_TEST_NTF_NEST`` | nested | all the results | > > + +-+-------------------------------------------+--------+---------------------+ > > + | | ``ETHTOOL_A_CABLE_TEST_STATUS`` | u8 | completed | > > + +-+-------------------------------------------+--------+---------------------+ > > You have ETHTOOL_A_CABLE_TEST_STATUS both here and on top level. AFAICS > the top level attribute is the right one - but the name is > ETHTOOL_A_CABLE_TEST_NTF_STATUS. Hi Michal They need better names. The first one is about the test run status. Started vs complete. A notification is sent when the test is started, and a second one at the end with the actual test results. The second status is per pair, indicating open, shorted, O.K. Maybe this second one shouldd be ETHTOOL_A_CABLE_TEST_NTF_PAIR_STATUS. There is also a cut/paste error, the second one should not have the comment completed. Andrew