From: SeongJae Park <sjpark@amazon.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: SeongJae Park <sjpark@amazon.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <gregkh@linuxfoundation.org>,
<edumazet@google.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, SeongJae Park <sjpark@amazon.de>
Subject: Re: RE: [PATCH net 0/2] Revert the 'socket_alloc' life cycle change
Date: Tue, 5 May 2020 16:24:37 +0200 [thread overview]
Message-ID: <20200505142437.22822-1-sjpark@amazon.com> (raw)
In-Reply-To: <20200505124442.GX23230@ZenIV.linux.org.uk>
On Tue, 5 May 2020 13:44:42 +0100 Al Viro <viro@zeniv.linux.org.uk> wrote:
> CAUTION: This email originated from outside of the organization. Do not cli=
> ck links or open attachments unless you can confirm the sender and know the=
> content is safe.
>
>
>
> On Tue, May 05, 2020 at 09:28:39AM +0200, SeongJae Park wrote:
> > From: SeongJae Park <sjpark@amazon.de>
> >
> > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
> > deallocation of 'socket_alloc' to be done asynchronously using RCU, as
> > same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate
> > socket_sq with socket itself") made those to have same life cycle.
> >
> > The changes made the code much more simple, but also made 'socket_alloc'
> > live longer than before. For the reason, user programs intensively
> > repeating allocations and deallocations of sockets could cause memory
> > pressure on recent kernels.
> >
> > To avoid the problem, this commit reverts the changes.
>
> Is it "could cause" or is it "have been actually observed to"?
Actually observed. Sorry for lack of that explanation. Could you please refer
to this link?
https://lore.kernel.org/netdev/20200505115402.25768-1-sjpark@amazon.com/
Thanks,
SeongJae Park
prev parent reply other threads:[~2020-05-05 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 7:28 [PATCH net 0/2] Revert the 'socket_alloc' life cycle change SeongJae Park
2020-05-05 7:28 ` [PATCH net 1/2] Revert "coallocate socket_wq with socket itself" SeongJae Park
2020-05-05 7:45 ` Greg KH
2020-05-05 8:04 ` SeongJae Park
2020-05-05 7:28 ` [PATCH net 2/2] Revert "sockfs: switch to ->free_inode()" SeongJae Park
2020-05-05 7:45 ` Greg KH
2020-05-05 8:09 ` SeongJae Park
2020-05-05 12:44 ` [PATCH net 0/2] Revert the 'socket_alloc' life cycle change Al Viro
2020-05-05 14:24 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505142437.22822-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjpark@amazon.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).