From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99749C47254 for ; Tue, 5 May 2020 19:36:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E030206FA for ; Tue, 5 May 2020 19:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729031AbgEETgj (ORCPT ); Tue, 5 May 2020 15:36:39 -0400 Received: from correo.us.es ([193.147.175.20]:36808 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728609AbgEETgj (ORCPT ); Tue, 5 May 2020 15:36:39 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id E2FAED2DA17 for ; Tue, 5 May 2020 21:36:37 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id D5218115410 for ; Tue, 5 May 2020 21:36:37 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id CF1312135D; Tue, 5 May 2020 21:36:37 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id D2A6C1158E2; Tue, 5 May 2020 21:36:35 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 05 May 2020 21:36:35 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id B215942EE38E; Tue, 5 May 2020 21:36:35 +0200 (CEST) Date: Tue, 5 May 2020 21:36:35 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jakub Kicinski Cc: Jiri Pirko , netfilter-devel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, ecree@solarflare.com, idosch@mellanox.com Subject: Re: [PATCH net,v2] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT_CARE Message-ID: <20200505193635.GA13114@salvia> References: <20200505174736.29414-1-pablo@netfilter.org> <20200505183643.GI14398@nanopsycho.orion> <20200505114616.221fc9af@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200505114616.221fc9af@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, May 05, 2020 at 11:46:16AM -0700, Jakub Kicinski wrote: > On Tue, 5 May 2020 20:36:43 +0200 Jiri Pirko wrote: > > Tue, May 05, 2020 at 07:47:36PM CEST, pablo@netfilter.org wrote: > > >This patch adds FLOW_ACTION_HW_STATS_DONT_CARE which tells the driver > > >that the frontend does not need counters, this hw stats type request > > >never fails. The FLOW_ACTION_HW_STATS_DISABLED type explicitly requests > > >the driver to disable the stats, however, if the driver cannot disable > > >counters, it bails out. > > > > > >TCA_ACT_HW_STATS_* maintains the 1:1 mapping with FLOW_ACTION_HW_STATS_* > > >except by disabled which is mapped to FLOW_ACTION_HW_STATS_DISABLED > > >(this is 0 in tc). Add tc_act_hw_stats() to perform the mapping between > > >TCA_ACT_HW_STATS_* and FLOW_ACTION_HW_STATS_*. > > > > > >Fixes: 319a1d19471e ("flow_offload: check for basic action hw stats type") > > >Signed-off-by: Pablo Neira Ayuso > > > > Looks great. Thanks! > > > > Reviewed-by: Jiri Pirko > > Is this going to "just work" for mlxsw? > > act = flow_action_first_entry_get(flow_action); > if (act->hw_stats == FLOW_ACTION_HW_STATS_ANY || > act->hw_stats == FLOW_ACTION_HW_STATS_IMMEDIATE) { > /* Count action is inserted first */ > err = mlxsw_sp_acl_rulei_act_count(mlxsw_sp, rulei, extack); > if (err) > return err; > } else if (act->hw_stats != FLOW_ACTION_HW_STATS_DISABLED) { > NL_SET_ERR_MSG_MOD(extack, "Unsupported action HW stats type"); > return -EOPNOTSUPP; > } > > if hw_stats is 0 we'll get into the else and bail. > > That doesn't deliver on the "don't care" promise, no? I can send a v3 to handle the _DONT_CARE type from the mlxsw. Thank you.