From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B581C28CBC for ; Wed, 6 May 2020 21:18:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D26F2076D for ; Wed, 6 May 2020 21:18:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729851AbgEFVSL (ORCPT ); Wed, 6 May 2020 17:18:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729162AbgEFVSL (ORCPT ); Wed, 6 May 2020 17:18:11 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED64EC061A0F; Wed, 6 May 2020 14:18:10 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 37697123229EC; Wed, 6 May 2020 14:18:10 -0700 (PDT) Date: Wed, 06 May 2020 14:18:09 -0700 (PDT) Message-Id: <20200506.141809.1664241067295315347.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: maxime.chevallier@bootlin.com, mcroce@redhat.com, rmk+kernel@armlinux.org.uk, antoine.tenart@bootlin.com, ioana.ciornei@nxp.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2 net] net: mvpp2: prevent buffer overflow in mvpp22_rss_ctx() From: David Miller In-Reply-To: <20200506101622.GB77004@mwanda> References: <20200506101622.GB77004@mwanda> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 May 2020 14:18:10 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Date: Wed, 6 May 2020 13:16:22 +0300 > The "rss_context" variable comes from the user via ethtool_get_rxfh(). > It can be any u32 value except zero. Eventually it gets passed to > mvpp22_rss_ctx() and if it is over MVPP22_N_RSS_TABLES (8) then it > results in an array overflow. > > Fixes: 895586d5dc32 ("net: mvpp2: cls: Use RSS contexts to handle RSS tables") > Signed-off-by: Dan Carpenter Applied.