* [PATCH] net: remove spurious declaration of tcp_default_init_rwnd()
@ 2020-05-07 7:58 Maciej Żenczykowski
2020-05-07 14:10 ` Eric Dumazet
2020-05-07 14:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Maciej Żenczykowski @ 2020-05-07 7:58 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller
Cc: Linux Network Development Mailing List
From: Maciej Żenczykowski <maze@google.com>
it doesn't actually exist...
Test: builds and 'git grep tcp_default_init_rwnd' comes up empty
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
include/net/tcp.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
index dcf9a72eeaa6..64f84683feae 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1376,7 +1376,6 @@ static inline void tcp_sack_reset(struct tcp_options_received *rx_opt)
rx_opt->num_sacks = 0;
}
-u32 tcp_default_init_rwnd(u32 mss);
void tcp_cwnd_restart(struct sock *sk, s32 delta);
static inline void tcp_slow_start_after_idle_check(struct sock *sk)
--
2.26.2.526.g744177e7f7-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: remove spurious declaration of tcp_default_init_rwnd()
2020-05-07 7:58 [PATCH] net: remove spurious declaration of tcp_default_init_rwnd() Maciej Żenczykowski
@ 2020-05-07 14:10 ` Eric Dumazet
2020-05-07 14:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2020-05-07 14:10 UTC (permalink / raw)
To: Maciej Żenczykowski, Maciej Żenczykowski,
David S . Miller
Cc: Linux Network Development Mailing List
On 5/7/20 12:58 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> it doesn't actually exist...
>
> Test: builds and 'git grep tcp_default_init_rwnd' comes up empty
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> include/net/tcp.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/net/tcp.h b/include/net/tcp.h
> index dcf9a72eeaa6..64f84683feae 100644
> --- a/include/net/tcp.h
> +++ b/include/net/tcp.h
> @@ -1376,7 +1376,6 @@ static inline void tcp_sack_reset(struct tcp_options_received *rx_opt)
> rx_opt->num_sacks = 0;
> }
>
> -u32 tcp_default_init_rwnd(u32 mss);
> void tcp_cwnd_restart(struct sock *sk, s32 delta);
>
> static inline void tcp_slow_start_after_idle_check(struct sock *sk)
>
Right, we should have removed this at the time commit a337531b942b
("tcp: up initial rmem to 128KB and SYN rwin to around 64KB") went in.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Thanks !
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: remove spurious declaration of tcp_default_init_rwnd()
2020-05-07 7:58 [PATCH] net: remove spurious declaration of tcp_default_init_rwnd() Maciej Żenczykowski
2020-05-07 14:10 ` Eric Dumazet
@ 2020-05-07 14:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-05-07 14:59 UTC (permalink / raw)
To: zenczykowski; +Cc: maze, netdev
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Thu, 7 May 2020 00:58:05 -0700
> From: Maciej Żenczykowski <maze@google.com>
>
> it doesn't actually exist...
>
> Test: builds and 'git grep tcp_default_init_rwnd' comes up empty
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-07 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-07 7:58 [PATCH] net: remove spurious declaration of tcp_default_init_rwnd() Maciej Żenczykowski
2020-05-07 14:10 ` Eric Dumazet
2020-05-07 14:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).