From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Edward Cree <ecree@solarflare.com>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, jiri@resnulli.us, kuba@kernel.org
Subject: Re: [PATCH net,v4] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT_CARE
Date: Thu, 7 May 2020 13:44:00 +0200 [thread overview]
Message-ID: <20200507114400.GA2179@salvia> (raw)
In-Reply-To: <828ef810-9768-5b5c-7847-0edeb666af9b@solarflare.com>
On Thu, May 07, 2020 at 11:38:24AM +0100, Edward Cree wrote:
> On 06/05/2020 19:34, Pablo Neira Ayuso wrote> - } else if (act->hw_stats != FLOW_ACTION_HW_STATS_DISABLED) {
> > + } else if (act->hw_stats != FLOW_ACTION_HW_STATS_DISABLED &&
> > + act->hw_stats != FLOW_ACTION_HW_STATS_DONT_CARE) {
> > NL_SET_ERR_MSG_MOD(extack, "Unsupported action HW stats type");
> > return -EOPNOTSUPP;
> > }
> FWIW my whole reason for suggesting DONT_CARE==0 in the first place
> was so that drivers could just use it as a boolean, e.g.
> if (act->hw_stats && !(act->hw_stats & FLOW_ACTION_HW_STATS_BLAH))
> error("driver only supports BLAH stats");
>
> If you're not even doing that then the case for DONT_CARE == ~0 is
> even stronger.
Could you point to what driver might have any problem with this update?
Thank you.
next prev parent reply other threads:[~2020-05-07 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 18:34 [PATCH net,v4] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT_CARE Pablo Neira Ayuso
2020-05-07 3:14 ` David Miller
2020-05-07 10:38 ` Edward Cree
2020-05-07 11:44 ` Pablo Neira Ayuso [this message]
2020-05-07 12:15 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507114400.GA2179@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox