From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CCCC38A2A for ; Thu, 7 May 2020 16:14:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7A4E2083B for ; Thu, 7 May 2020 16:14:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YU6c+N8c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbgEGQOL (ORCPT ); Thu, 7 May 2020 12:14:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726467AbgEGQOK (ORCPT ); Thu, 7 May 2020 12:14:10 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 587D5C05BD43 for ; Thu, 7 May 2020 09:14:10 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id o134so7540200yba.18 for ; Thu, 07 May 2020 09:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=elZRWiJacHTByu3IDRfBXpMhoFL/CH5h+5bxsr2OQXg=; b=YU6c+N8c+ZcLIZIBNoMxjFMalwkY43lobROB9W5vcW+Bhu/T1vaiSLF2ST3K06fV2G LRh18fw6EkndZPRUfXLGFv78n+AoZYQjSm4vsyCrhVBSJqvjAQYgA63U5wrx2XFwpJSf CLIsBrogp9KUAX6xqbkprvhie5Z3a7oqE1w3GKpnpcQAAI+NkKEb/Zymk7Iwq7Aw1/0Z gp3bi2oyFnb6RxYWUUpliM9Wj9wOX/rIl0fBK/aMvgSFMv+A3iwoL4RjtNuwYhL4H8Ir 6TEeLEUBPV74RfZVl1jHRYjxwLHNbyXCwRNDBkxB8F0z7cZ54wKhhiobjIWBv4znkgGl Ntag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=elZRWiJacHTByu3IDRfBXpMhoFL/CH5h+5bxsr2OQXg=; b=LpBhr37E3gC7gEVKCEgVJ7VM8dKjRaNjzagzprxNqGGzvJ6bEDKlhzLsITwoNGJxgw pqk2ePJh29UsuBnng10egE4n1IThp7Ki+zefZaXQZ8aauXpuphsZmx0h0fAdUJvwLuHp yqWXNQk/1LfcKXlqkB6wsZvN7Rd3IEVNrFTYMGUQDtN/5FrFplf1F4a+zrGGFahZ6zM1 cvdPcseFAJxH0U+xWkZlkyYYa2UaYiO8TTygN4CfrEN6ZdWN32sgmXS+z5CJRGcTdsLn LQN/DnH9Smnl2vUHSiUEqtkhmXPoFjWrRS6gxE7T8lrc5yjQFPAh9fMIz7FhtXTYRbtZ uCxA== X-Gm-Message-State: AGi0PuZ/S5Ov35slmQlhtbFn7ThI96wuCsaPMQQBm15aWGArk40KgXsQ hQQSXdpbPI6EtpsCiqBOJwUBoLw= X-Google-Smtp-Source: APiQypIcboNK6ML7gfW53TddA6VnCRdOaiBdLjWa0oUaxLBwFcX+wPnb9BzmKAXPxB7wwo1gK2HR77I= X-Received: by 2002:a25:d705:: with SMTP id o5mr23643576ybg.219.1588868049600; Thu, 07 May 2020 09:14:09 -0700 (PDT) Date: Thu, 7 May 2020 09:14:07 -0700 In-Reply-To: <20200507061244.63ztqtmiid64xptv@kafai-mbp> Message-Id: <20200507161407.GJ241848@google.com> Mime-Version: 1.0 References: <20200506223210.93595-1-sdf@google.com> <20200506223210.93595-4-sdf@google.com> <20200507061244.63ztqtmiid64xptv@kafai-mbp> Subject: Re: [PATCH bpf-next v3 3/5] selftests/bpf: move existing common networking parts into network_helpers From: sdf@google.com To: Martin KaFai Lau Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 05/06, Martin KaFai Lau wrote: > On Wed, May 06, 2020 at 03:32:08PM -0700, Stanislav Fomichev wrote: > > 1. Move pkt_v4 and pkt_v6 into network_helpers and adjust the users. > > 2. Copy-paste spin_lock_thread into two tests that use it. > Instead of copying it into two tests, > can spin_lock_thread be moved to network-helpers.c? spin_lock_thread doesn't look like something that can be reused by other networking tests and looks very specific to prog_tests/spinlock.c and prog_tests/map_lock.c. It might be better with the copy-paste now because that thread definition is closer to the place that uses it. I don't feel strongly about it and can put it into network_helpers. Let me know if you prefer it that way.