From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E821C38A24 for ; Thu, 7 May 2020 16:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6499B2073A for ; Thu, 7 May 2020 16:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588869336; bh=ftKzAclNdYnJO3VmiOnD3bLpHCmg3zx3FPWNVr0ERmU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qgNSsHQyzR6bWKF/hb92pGI18U0DGvbu3ytJRiOhQ44qAyq01TyP9TiNIknZrEKQ4 fxz47vGuG5BT3PaAJBXwXTzjiXT26cJdGqt17VSm+NR+MNWN3C9fvg2V8qN6wanoKs xogx05r07ztQWNZCDvl/fxWnFCAap4+n2I23YU30= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726521AbgEGQff (ORCPT ); Thu, 7 May 2020 12:35:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:57998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726222AbgEGQff (ORCPT ); Thu, 7 May 2020 12:35:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CABF920643; Thu, 7 May 2020 16:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588869333; bh=ftKzAclNdYnJO3VmiOnD3bLpHCmg3zx3FPWNVr0ERmU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tt6zOSxYYKCZ/US+zVoiEaqNdp/S3UTLc98sD0nHpRaBJofsji6j53gKSe2dESW5i ZrCnVgK5F0b9Ph/G43yRhjaItFJ1JQwBhILRPq8qeyV0i148yjbLxxAZN1N6cnsE0a SQ51AYYU3a9KVodtpfDtjoifyEZeKghQHWP2k/Tg= Date: Thu, 7 May 2020 18:35:31 +0200 From: Greg KH To: Edward Cree Cc: "Saleem, Shiraz" , "Kirsher, Jeffrey T" , "davem@davemloft.net" , "Ertman, David M" , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "nhorman@redhat.com" , "sassmann@redhat.com" , "jgg@ziepe.ca" , "ranjani.sridharan@linux.intel.com" , "pierre-louis.bossart@linux.intel.com" , "Nguyen, Anthony L" , "Bowers, AndrewX" , Martin Habets Subject: Re: [net-next v3 2/9] ice: Create and register virtual bus for RDMA Message-ID: <20200507163531.GA2100062@kroah.com> References: <20200506210505.507254-1-jeffrey.t.kirsher@intel.com> <20200506210505.507254-3-jeffrey.t.kirsher@intel.com> <20200507081737.GC1024567@kroah.com> <9DD61F30A802C4429A01CA4200E302A7DCD6B850@fmsmsx124.amr.corp.intel.com> <20200507150658.GA1886648@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, May 07, 2020 at 04:24:32PM +0100, Edward Cree wrote: > On 07/05/2020 16:06, Greg KH wrote: > > I can't accept that this series is using a virtual bus properly without > > actually using the virtual bus driver code, can you? > I might be misunderstanding, but I *think* a hardware driver likeice is >  the 'provider' of a virtbus, and it's only 'consumers' of it (like an >  RDMA device talking to that ice instance) that are virtbus_drivers. > Though tbh I'm not entirely happy either with a series that adds the >  provider side but not any users... and either way, the documentation >  *really* doesn't make it clear whether it works the way I think it does >  or not. Exactly, I can't tell anything from the documentation at all, so I looked at how the code was used. That just made things worse... This needs more work. greg k-h