From: Tony Lindgren <tony@atomide.com>
To: Philippe Schenker <philippe.schenker@toradex.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
"o.rempel@pengutronix.de" <o.rempel@pengutronix.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH v2] ARM: dts: am437x: fix networking on boards with ksz9031 phy
Date: Thu, 7 May 2020 10:52:19 -0700 [thread overview]
Message-ID: <20200507175219.GX37466@atomide.com> (raw)
In-Reply-To: <91c1ba87f2dfa66e11681d2660782a2efce2615d.camel@toradex.com>
* Philippe Schenker <philippe.schenker@toradex.com> [200507 15:17]:
> On Thu, 2020-05-07 at 18:12 +0300, Grygorii Strashko wrote:
> > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for
> > the
> > KSZ9031 PHY") the networking is broken on boards:
> > am437x-gp-evm
> > am437x-sk-evm
> > am437x-idk-evm
> >
> > All above boards have phy-mode = "rgmii" and this is worked before,
> > because
> > KSZ9031 PHY started with default RGMII internal delays configuration
> > (TX
> > off, RX on 1.2 ns) and MAC provided TX delay. After above commit, the
> > KSZ9031 PHY starts handling phy mode properly and disables RX delay,
> > as
> > result networking is become broken.
> >
> > Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
> > behavior.
> >
> > Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> > Cc: Andrew Lunn <andrew@lunn.ch>
> > Cc: Philippe Schenker <philippe.schenker@toradex.com>
> > Fixes: commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support
> > for the KSZ9031 PHY")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> Reviewed-by: Philippe Schenker <philippe.schenker@toradex.com>
Thanks applying into fixes.
Tony
prev parent reply other threads:[~2020-05-07 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 15:12 [PATCH v2] ARM: dts: am437x: fix networking on boards with ksz9031 phy Grygorii Strashko
2020-05-07 15:16 ` Philippe Schenker
2020-05-07 17:52 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507175219.GX37466@atomide.com \
--to=tony@atomide.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=philippe.schenker@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).