From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E28F8C28CBC for ; Sat, 9 May 2020 06:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7EBB24955 for ; Sat, 9 May 2020 06:36:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589006195; bh=RFbnhgSPUl+r0VW77nag8XOSxtrStomceAWtwpDsOjI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=S7zzyKKpmN7GLWfmiSb5xkpDFvt+LGS4+w6nLQ8mQTDApZF6age25vkOEaH3G/MYF wQ/1T3NBR+O5hcmeGKjkmdIGIE7+T0iPlZLSrs88LQNGJSa3EcMd4cO56a0Jj3ZaNF lY3qXLG7UXS8472W5gZmJoGFPHhX96Y5yZnzmotI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728897AbgEIGge (ORCPT ); Sat, 9 May 2020 02:36:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:58362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbgEIGge (ORCPT ); Sat, 9 May 2020 02:36:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 870EF21582; Sat, 9 May 2020 06:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589006194; bh=RFbnhgSPUl+r0VW77nag8XOSxtrStomceAWtwpDsOjI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lLKesJ9KUeIgRcM/ODpIoyeaFnGG7xf9f070/bn4oZ3OpWJFe1ROJMsLuiyHMRV+4 ym9wP/zEAijq3XJcQkbTT82yoYUZFWK6hgAbqLJkR+giMlMjZfbmm5G8iiWjl80Z7z +k9YkG+bvBKsNtjvNDMYyRIeT1spG19CEiwMB4EU= Date: Sat, 9 May 2020 08:36:31 +0200 From: Greg Kroah-Hartman To: Russell King - ARM Linux admin Cc: Matteo Croce , David Miller , Andrew Lunn , Florian Fainelli , Heiner Kallweit , netdev Subject: Re: [PATCH net v2 0/2] Fix 88x3310 leaving power save mode Message-ID: <20200509063631.GA1691791@kroah.com> References: <20200414194753.GB25745@shell.armlinux.org.uk> <20200414.164825.457585417402726076.davem@davemloft.net> <20200508213816.GY1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508213816.GY1551@shell.armlinux.org.uk> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 08, 2020 at 10:38:16PM +0100, Russell King - ARM Linux admin wrote: > On Fri, May 08, 2020 at 11:32:39PM +0200, Matteo Croce wrote: > > On Wed, Apr 15, 2020 at 1:48 AM David Miller wrote: > > > > > > From: Russell King - ARM Linux admin > > > Date: Tue, 14 Apr 2020 20:47:53 +0100 > > > > > > > This series fixes a problem with the 88x3310 PHY on Macchiatobin > > > > coming out of powersave mode noticed by Matteo Croce. It seems > > > > that certain PHY firmwares do not properly exit powersave mode, > > > > resulting in a fibre link not coming up. > > > > > > > > The solution appears to be to soft-reset the PHY after clearing > > > > the powersave bit. > > > > > > > > We add support for reporting the PHY firmware version to the kernel > > > > log, and use it to trigger this new behaviour if we have v0.3.x.x > > > > or more recent firmware on the PHY. This, however, is a guess as > > > > the firmware revision documentation does not mention this issue, > > > > and we know that v0.2.1.0 works without this fix but v0.3.3.0 and > > > > later does not. > > > > > > Series applied, thanks. > > > > > > > Hi, > > > > should we queue this to -stable? > > The 10 gbit ports don't work without this fix. > > It has a "Fixes:" tag, so it should be backported automatically. That is a wild guess that it might happen sometime in the future. Please use the cc: stable@ tag as is documented for the past 15+ years instead of relying on us to randomly notice a Fixes: tag. thanks, greg k-h