From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] r8169: rely on sanity checks in phy_ethtool_set_eee
Date: Sun, 10 May 2020 15:08:01 +0100 [thread overview]
Message-ID: <20200510140801.GN1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <104d788a-68ee-9669-f920-656dcb1e6d83@gmail.com>
On Sun, May 10, 2020 at 10:12:40AM +0200, Heiner Kallweit wrote:
> These checks are integrated in phy_ethtool_set_eee() now, therefore we
> can remove them from the driver.
Ah, so one NIC driver has a problem with this, so we have to apply that
pain to all NIC drivers? No thanks.
Have you looked at how the driver decides whether EEE should be enabled?
Does it check that the link negotiated FD prior to enabling EEE? That
is likely where the problem is.
Throwing big hammers to prevent the user configuring EEE settings on any
driver just because one driver has a problem is really not a sane
approach, and in fact I can tell you now that I will be pointing out a
userspace regression as a result of your patches - I can tell you now,
your patch 1 _will_ regress my userspace.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
prev parent reply other threads:[~2020-05-10 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 8:10 [PATCH net-next 0/2] net: phy: check for aneg disabled and half duplex in phy_ethtool_set_eee Heiner Kallweit
2020-05-10 8:11 ` [PATCH net-next 1/2] " Heiner Kallweit
2020-05-10 14:05 ` Russell King - ARM Linux admin
2020-05-11 12:50 ` Heiner Kallweit
2020-05-11 13:22 ` Russell King - ARM Linux admin
2020-05-10 8:12 ` [PATCH net-next 2/2] r8169: rely on sanity checks " Heiner Kallweit
2020-05-10 14:08 ` Russell King - ARM Linux admin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510140801.GN1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).