From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Roi Dayan <roid@mellanox.com>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
davem@davemloft.net, Paul Blakey <paulb@mellanox.com>,
Oz Shlomo <ozsh@mellanox.com>,
Marcelo Ricardo Leitner <mleitner@redhat.com>
Subject: Re: [PATCH net] netfilter: nf_flow_table_offload: Remove WQ_MEM_RECLAIM from workqueue
Date: Mon, 11 May 2020 19:28:02 +0200 [thread overview]
Message-ID: <20200511172802.GA2064@salvia> (raw)
In-Reply-To: <20200510105543.13546-1-roid@mellanox.com>
On Sun, May 10, 2020 at 01:55:43PM +0300, Roi Dayan wrote:
> This workqueue is in charge of handling offloaded flow tasks like
> add/del/stats we should not use WQ_MEM_RECLAIM flag.
> The flag can result in the following warning.
>
> [ 485.557189] ------------[ cut here ]------------
> [ 485.562976] workqueue: WQ_MEM_RECLAIM nf_flow_table_offload:flow_offload_worr
> [ 485.562985] WARNING: CPU: 7 PID: 3731 at kernel/workqueue.c:2610 check_flush0
> [ 485.590191] Kernel panic - not syncing: panic_on_warn set ...
> [ 485.597100] CPU: 7 PID: 3731 Comm: kworker/u112:8 Not tainted 5.7.0-rc1.21802
> [ 485.606629] Hardware name: Dell Inc. PowerEdge R730/072T6D, BIOS 2.4.3 01/177
> [ 485.615487] Workqueue: nf_flow_table_offload flow_offload_work_handler [nf_f]
> [ 485.624834] Call Trace:
> [ 485.628077] dump_stack+0x50/0x70
> [ 485.632280] panic+0xfb/0x2d7
> [ 485.636083] ? check_flush_dependency+0x110/0x130
> [ 485.641830] __warn.cold.12+0x20/0x2a
> [ 485.646405] ? check_flush_dependency+0x110/0x130
> [ 485.652154] ? check_flush_dependency+0x110/0x130
> [ 485.657900] report_bug+0xb8/0x100
> [ 485.662187] ? sched_clock_cpu+0xc/0xb0
> [ 485.666974] do_error_trap+0x9f/0xc0
> [ 485.671464] do_invalid_op+0x36/0x40
> [ 485.675950] ? check_flush_dependency+0x110/0x130
> [ 485.681699] invalid_op+0x28/0x30
Applied, thanks.
prev parent reply other threads:[~2020-05-11 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 10:55 [PATCH net] netfilter: nf_flow_table_offload: Remove WQ_MEM_RECLAIM from workqueue Roi Dayan
2020-05-11 17:28 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511172802.GA2064@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ozsh@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).