From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Julien Beraud <julien.beraud@orolia.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: net: phylink: supported modes set to 0 with genphy sfp module
Date: Mon, 11 May 2020 19:29:54 +0100 [thread overview]
Message-ID: <20200511182954.GV1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <0ee8416c-dfa2-21bc-2688-58337bfa1e2a@orolia.com>
On Mon, May 11, 2020 at 05:45:02PM +0200, Julien Beraud wrote:
> Following commit:
>
> commit 52c956003a9d5bcae1f445f9dfd42b624adb6e87
> Author: Russell King <rmk+kernel@armlinux.org.uk>
> Date: Wed Dec 11 10:56:45 2019 +0000
>
> net: phylink: delay MAC configuration for copper SFP modules
>
>
> In function phylink_sfp_connect_phy, phylink_sfp_config is called before
> phylink_attach_phy.
>
> In the case of a genphy, the "supported" field of the phy_device is filled
> by:
> phylink_attach_phy->phy_attach_direct->phy_probe->genphy_read_abilities.
>
> It means that:
>
> ret = phylink_sfp_config(pl, mode, phy->supported, phy->advertising);
> will have phy->supported with no bits set, and then the first call to
> phylink_validate in phylink_sfp_config will return an error:
>
> return phylink_is_empty_linkmode(supported) ? -EINVAL : 0;
>
> this results in putting the sfp driver in "failed" state.
Which PHY is this?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
next prev parent reply other threads:[~2020-05-11 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 15:45 net: phylink: supported modes set to 0 with genphy sfp module Julien Beraud
2020-05-11 18:29 ` Russell King - ARM Linux admin [this message]
2020-05-11 19:06 ` Florian Fainelli
2020-05-12 9:28 ` Julien Beraud
2020-05-12 12:28 ` Russell King - ARM Linux admin
2020-05-13 7:14 ` Julien Beraud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511182954.GV1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=julien.beraud@orolia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).