netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc: chuck.lever@oracle.com, trond.myklebust@hammerspace.com,
	anna.schumaker@netapp.com, davem@davemloft.net, kuba@kernel.org,
	linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' by sysfs
Date: Mon, 11 May 2020 20:21:12 -0400	[thread overview]
Message-ID: <20200512002112.GA17212@fieldses.org> (raw)
In-Reply-To: <1588901580-44687-2-git-send-email-wangxiongfeng2@huawei.com>

On Fri, May 08, 2020 at 09:32:59AM +0800, Xiongfeng Wang wrote:
> When I cat parameter '/sys/module/sunrpc/parameters/pool_mode', it
> displays as follows. It is better to add a newline for easy reading.

Applying for 5.8.  I assume Trond's getting the other patch.

--b.

> 
> [root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/pool_mode
> global[root@hulk-202 ~]#
> 
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> ---
>  net/sunrpc/svc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index 187dd4e..d8ef47f 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -88,15 +88,15 @@ struct svc_pool_map svc_pool_map = {
>  	switch (*ip)
>  	{
>  	case SVC_POOL_AUTO:
> -		return strlcpy(buf, "auto", 20);
> +		return strlcpy(buf, "auto\n", 20);
>  	case SVC_POOL_GLOBAL:
> -		return strlcpy(buf, "global", 20);
> +		return strlcpy(buf, "global\n", 20);
>  	case SVC_POOL_PERCPU:
> -		return strlcpy(buf, "percpu", 20);
> +		return strlcpy(buf, "percpu\n", 20);
>  	case SVC_POOL_PERNODE:
> -		return strlcpy(buf, "pernode", 20);
> +		return strlcpy(buf, "pernode\n", 20);
>  	default:
> -		return sprintf(buf, "%d", *ip);
> +		return sprintf(buf, "%d\n", *ip);
>  	}
>  }
>  
> -- 
> 1.7.12.4

  reply	other threads:[~2020-05-12  0:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08  1:32 [PATCH 0/2] sunrpc: add missing newline when printing module parameters by sysfs Xiongfeng Wang
2020-05-08  1:32 ` [PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' " Xiongfeng Wang
2020-05-12  0:21   ` J. Bruce Fields [this message]
2020-05-08  1:33 ` [PATCH 2/2] sunrpc: add missing newline when printing parameter 'auth_hashtable_size' " Xiongfeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512002112.GA17212@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=anna.schumaker@netapp.com \
    --cc=chuck.lever@oracle.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    --cc=wangxiongfeng2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).